Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 995713002: Service Worker: Don't record StartWorker metrics for a doomed worker. (Closed)

Created:
5 years, 9 months ago by falken
Modified:
5 years, 9 months ago
Reviewers:
kinuko, nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@coalesce_more
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Service Worker: Don't record StartWorker metrics for a doomed worker. This happens a lot because the update check sees the worker is byte-by-byte identical and then dooms the worker before it finishes starting. BUG=448003 Committed: https://crrev.com/0c55bbd9a4936f01be865b2efb4eecd7201c5c40 Cr-Commit-Position: refs/heads/master@{#319854}

Patch Set 1 #

Patch Set 2 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M content/browser/service_worker/service_worker_version.cc View 1 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
falken
PTL
5 years, 9 months ago (2015-03-10 08:17:04 UTC) #2
nhiroki
lgtm
5 years, 9 months ago (2015-03-10 08:29:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995713002/20001
5 years, 9 months ago (2015-03-10 08:36:04 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-10 09:44:10 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 09:44:38 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0c55bbd9a4936f01be865b2efb4eecd7201c5c40
Cr-Commit-Position: refs/heads/master@{#319854}

Powered by Google App Engine
This is Rietveld 408576698