sync/engine/directory_update_handler_unittest.cc - Issue 995683002: Revert of [Sync] Add size and crc32c to AttachmentId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/engine/directory_update_handler_unittest.cc

Issue 995683002: Revert of [Sync] Add size and crc32c to AttachmentId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sync/engine/directory_commit_contribution_unittest.cc ('k') | sync/internal_api/attachments/attachment_downloader_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/engine/directory_update_handler_unittest.cc

diff --git a/sync/engine/directory_update_handler_unittest.cc b/sync/engine/directory_update_handler_unittest.cc

index 2311d0fce83f41c8086b22d13f483d5714113db3..46e286015f5bd1af7b8f244b71d9c701a6ace4f5 100644

--- a/sync/engine/directory_update_handler_unittest.cc

+++ b/sync/engine/directory_update_handler_unittest.cc

@@ -401,7 +401,7 @@

scoped_ptr<sync_pb::SyncEntity> e1 = CreateUpdate(

SyncableIdToProto(Id::CreateFromServerId("e1")), "", ARTICLES);

sync_pb::AttachmentIdProto* attachment_id = e1->add_attachment_id();

- *attachment_id = CreateAttachmentIdProto(0, 0);

+ *attachment_id = CreateAttachmentIdProto();

SyncEntityList updates;

updates.push_back(e1.get());

@@ -1080,10 +1080,8 @@

*specifics.mutable_article() = sync_pb::ArticleSpecifics();

int64 handle = entry_factory()->CreateSyncedItem("art1", ARTICLES, is_folder);

- sync_pb::AttachmentIdProto local_attachment_id =

- CreateAttachmentIdProto(0, 0);

- sync_pb::AttachmentIdProto server_attachment_id =

- CreateAttachmentIdProto(0, 0);

+ sync_pb::AttachmentIdProto local_attachment_id = CreateAttachmentIdProto();

+ sync_pb::AttachmentIdProto server_attachment_id = CreateAttachmentIdProto();

// Add an attachment to the local attachment metadata.

sync_pb::AttachmentMetadata local_metadata;

@@ -1124,8 +1122,8 @@

*specifics.mutable_article() = sync_pb::ArticleSpecifics();

int64 handle = entry_factory()->CreateSyncedItem("art1", ARTICLES, is_folder);

- sync_pb::AttachmentIdProto id1 = CreateAttachmentIdProto(0, 0);

- sync_pb::AttachmentIdProto id2 = CreateAttachmentIdProto(0, 0);

+ sync_pb::AttachmentIdProto id1 = CreateAttachmentIdProto();

+ sync_pb::AttachmentIdProto id2 = CreateAttachmentIdProto();

// Add id1, then id2 to the local attachment metadata.

sync_pb::AttachmentMetadata local_metadata;