sync/internal_api/public/base/attachment_id_proto.h - Issue 995683002: Revert of [Sync] Add size and crc32c to AttachmentId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/base/attachment_id_proto.h

Issue 995683002: Revert of [Sync] Add size and crc32c to AttachmentId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sync/internal_api/public/attachments/attachment_downloader_impl.h ('k') | sync/internal_api/public/base/attachment_id_proto.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/public/base/attachment_id_proto.h

diff --git a/sync/internal_api/public/base/attachment_id_proto.h b/sync/internal_api/public/base/attachment_id_proto.h

index 9af3a9866b4ded7f2cd249df713749a8c5591191..a47f46e2e43c1c211021401e27b527d41438fffd 100644

--- a/sync/internal_api/public/base/attachment_id_proto.h

+++ b/sync/internal_api/public/base/attachment_id_proto.h

@@ -5,7 +5,6 @@

#ifndef SYNC_INTERNAL_API_PUBLIC_BASE_ATTACHMENT_ID_PROTO_H_

#define SYNC_INTERNAL_API_PUBLIC_BASE_ATTACHMENT_ID_PROTO_H_

-#include "base/basictypes.h"

#include "sync/base/sync_export.h"

#include "sync/protocol/sync.pb.h"

@@ -14,13 +13,7 @@

// Helper functions that are logically part of sync_pb::AttachmentIdProto.

// Creates a unique AttachmentIdProto.

-//

-// |size| is the size in bytes of the attachment identified by this proto.

-//

-// |crc32c| is the crc32c of the attachment identified by this proto.

-SYNC_EXPORT_PRIVATE sync_pb::AttachmentIdProto CreateAttachmentIdProto(

- size_t size,

- uint32_t crc32c);

+SYNC_EXPORT_PRIVATE sync_pb::AttachmentIdProto CreateAttachmentIdProto();

// Creates an AttachmentMetadata object from a repeated field of

// AttachmentIdProto objects.