Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: sync/api/attachments/attachment.cc

Issue 995683002: Revert of [Sync] Add size and crc32c to AttachmentId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sync/api/attachments/attachment.h ('k') | sync/api/attachments/attachment_id.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/api/attachments/attachment.h" 5 #include "sync/api/attachments/attachment.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "sync/internal_api/public/attachments/attachment_util.h" 8 #include "sync/internal_api/public/attachments/attachment_util.h"
9 9
10 namespace syncer { 10 namespace syncer {
11 11
12 Attachment::~Attachment() {} 12 Attachment::~Attachment() {}
13 13
14 // Static. 14 // Static.
15 Attachment Attachment::Create( 15 Attachment Attachment::Create(
16 const scoped_refptr<base::RefCountedMemory>& data) { 16 const scoped_refptr<base::RefCountedMemory>& data) {
17 uint32_t crc32c = ComputeCrc32c(data); 17 uint32_t crc32c = ComputeCrc32c(data);
18 return CreateFromParts(AttachmentId::Create(data->size(), crc32c), data); 18 return CreateFromParts(AttachmentId::Create(), data, crc32c);
19 } 19 }
20 20
21 // Static. 21 // Static.
22 Attachment Attachment::CreateFromParts( 22 Attachment Attachment::CreateFromParts(
23 const AttachmentId& id, 23 const AttachmentId& id,
24 const scoped_refptr<base::RefCountedMemory>& data) { 24 const scoped_refptr<base::RefCountedMemory>& data,
25 return Attachment(id, data); 25 uint32_t crc32c) {
26 return Attachment(id, data, crc32c);
26 } 27 }
27 28
28 const AttachmentId& Attachment::GetId() const { return id_; } 29 const AttachmentId& Attachment::GetId() const { return id_; }
29 30
30 const scoped_refptr<base::RefCountedMemory>& Attachment::GetData() const { 31 const scoped_refptr<base::RefCountedMemory>& Attachment::GetData() const {
31 return data_; 32 return data_;
32 } 33 }
33 34
34 uint32_t Attachment::GetCrc32c() const { 35 uint32_t Attachment::GetCrc32c() const { return crc32c_; }
35 return id_.GetCrc32c();
36 }
37 36
38 Attachment::Attachment(const AttachmentId& id, 37 Attachment::Attachment(const AttachmentId& id,
39 const scoped_refptr<base::RefCountedMemory>& data) 38 const scoped_refptr<base::RefCountedMemory>& data,
40 : id_(id), data_(data) { 39 uint32_t crc32c)
41 DCHECK_EQ(id.GetSize(), data->size()); 40 : id_(id), data_(data), crc32c_(crc32c) {
42 DCHECK(data.get()); 41 DCHECK(data.get());
43 } 42 }
44 43
45 } // namespace syncer 44 } // namespace syncer
OLDNEW
« no previous file with comments | « sync/api/attachments/attachment.h ('k') | sync/api/attachments/attachment_id.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698