android_webview/java/src/org/chromium/android_webview/AwMessagePortService.java - Issue 995663002: Implement receiving transferred ports from JS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwMessagePortService.java

Issue 995663002: Implement receiving transferred ports from JS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@flaky-test

Patch Set: address nit from nasko Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/aw_message_port_message_filter.cc ('k') | android_webview/java/src/org/chromium/android_webview/MessagePort.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwMessagePortService.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwMessagePortService.java b/android_webview/java/src/org/chromium/android_webview/AwMessagePortService.java

index 626d427473197bddf14472a170c098cfdbcc7817..e7c887b29ba17775a14901619844eb67dde4d2f8 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwMessagePortService.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwMessagePortService.java

@@ -144,8 +144,14 @@ public class AwMessagePortService {

// Called on IO thread.

@CalledByNative

private void onReceivedMessage(int portId, String message, int[] ports) {

- // TODO(sgurun) implement receiving ports from native

- mPortStorage.get(portId).onReceivedMessage(message);

+ MessagePort[] messagePorts = null;

+ for (int i = 0; i < ports.length; i++) {

+ if (messagePorts == null) {

+ messagePorts = new MessagePort[ports.length];

+ }

+ messagePorts[i] = addPort(new MessagePort(this), ports[i]);

+ }

+ mPortStorage.get(portId).onReceivedMessage(message, messagePorts);

}

@CalledByNative