Issue 995613002: Implement a basic IME-aware input element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 995613002: Implement a basic IME-aware input element (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
eseidel

CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Implement a basic IME-aware input element This CL introduces a new keyboard service that understands Android IME and starts work on a Input component that interacts with this service to provide an editing control. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8b335e3362e5ad73f6cd41362ea3887636d6e1b9

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+284 lines, -12 lines)			Patch
M	sky/apk/demo/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/apk/demo/org/domokit/sky/demo/SkyDemoApplication.java	View	2 chunks	+9 lines, -0 lines	0 comments	Download
A +	sky/examples/editor/editor_app.dart	View	1 chunk	+7 lines, -8 lines	0 comments	Download
A	sky/examples/editor/index.sky	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A	sky/examples/editor/input.dart	View	1 chunk	+111 lines, -0 lines	0 comments	Download
A +	sky/services/keyboard/BUILD.gn	View	2 chunks	+4 lines, -4 lines	0 comments	Download
A	sky/services/keyboard/keyboard.mojom	View	1 chunk	+16 lines, -0 lines	0 comments	Download
A	sky/services/keyboard/org/domokit/keyboard/InputConnectionAdaptor.java	View	1 chunk	+46 lines, -0 lines	0 comments	Download
A	sky/services/keyboard/org/domokit/keyboard/KeyboardServiceImpl.java	View	1 chunk	+64 lines, -0 lines	0 comments	Download
M	sky/shell/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/shell/org/domokit/sky/shell/PlatformView.java	View	4 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 9 months ago (2015-03-09 23:20:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8b335e3362e5ad73f6cd41362ea3887636d6e1b9 (presubmit successful).

Expand Messages | Collapse Messages