Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 99553005: silence has_changed_character may be used uninitialized warning (Closed)

Created:
6 years, 12 months ago by Mostyn Bramley-Moore
Modified:
6 years, 11 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@master
Visibility:
Public.

Description

silence has_changed_character may be used uninitialized warning Some slightly older versions of gcc aren't clever enough to figure out that this variable won't be used if the return value from the function that initializes it is false. Tested with gcc 4.5.1. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Mostyn Bramley-Moore
@Yang: PTAL at this tiny patch.
6 years, 12 months ago (2013-12-24 14:51:39 UTC) #1
Yang
LGTM. I'll land this after the holidays.
6 years, 12 months ago (2013-12-24 15:26:03 UTC) #2
Mostyn Bramley-Moore
Thanks. No rush, have a good break :)
6 years, 12 months ago (2013-12-24 16:15:56 UTC) #3
Yang
Benedikt, could you please help me land this patch? It looks like I won't be ...
6 years, 11 months ago (2014-01-03 20:11:54 UTC) #4
Benedikt Meurer
On 2014/01/03 20:11:54, Yang wrote: > Benedikt, could you please help me land this patch? ...
6 years, 11 months ago (2014-01-04 18:18:54 UTC) #5
Benedikt Meurer
6 years, 11 months ago (2014-01-04 18:20:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r18456.

Powered by Google App Engine
This is Rietveld 408576698