Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 99553002: cc: Prevent ResourceUpdateContoller from uploading textures after lost context (Closed)

Created:
7 years ago by reveman
Modified:
7 years ago
Reviewers:
danakj, brianderson
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Prevent ResourceUpdateContoller from uploading textures after lost context If the context was lost in the middle of the ResourceUpdateController uploading textures, it would previously continue uploading textures. ResourceUpdateController now stops uploading immediately and notifies its client that the uploads have completed, which will allow the commit to complete. The LayerTreeHostContextTestLostContextWhileUpdatingResources unit test now relys on the first draw to trigger the end of the test. Relying on the first commit to end the test was incorrect before this patch and would be incorrect after this patch, since losing the context doesn't prevent the commit from finishing. Previously, the end of the test was racing with the expected number of times the context would be lost. In order to rely on the first draw to end the test, SingleThreadProxy now checks for lost context before drawing. BUG=313790 TBR=danakj Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238178

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -60 lines) Patch
M cc/resources/resource_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/resources/resource_provider.cc View 3 chunks +24 lines, -8 lines 0 comments Download
M cc/resources/resource_update_controller.h View 2 chunks +1 line, -3 lines 0 comments Download
M cc/resources/resource_update_controller.cc View 3 chunks +6 lines, -24 lines 0 comments Download
M cc/resources/resource_update_controller_unittest.cc View 7 chunks +16 lines, -12 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reveman
7 years ago (2013-12-02 17:37:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/99553002/1
7 years ago (2013-12-02 17:39:40 UTC) #2
commit-bot: I haz the power
7 years ago (2013-12-02 20:52:22 UTC) #3
Message was sent while issue was closed.
Change committed as 238178

Powered by Google App Engine
This is Rietveld 408576698