Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Unified Diff: chrome/browser/ui/views/message_center/web_notification_tray.cc

Issue 99543003: Fix popup crash on ChromeOS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/message_center/web_notification_tray.cc
diff --git a/chrome/browser/ui/views/message_center/web_notification_tray.cc b/chrome/browser/ui/views/message_center/web_notification_tray.cc
index 6c6675f6d4712a2918ed4e323d4ab825a0531549..88124f328ae8d67f210a29882c1d2541f1e4b3fa 100644
--- a/chrome/browser/ui/views/message_center/web_notification_tray.cc
+++ b/chrome/browser/ui/views/message_center/web_notification_tray.cc
@@ -152,7 +152,12 @@ bool WebNotificationTray::ShowPopups() {
return true;
}
-void WebNotificationTray::HidePopups() { popup_collection_.reset(); }
+void WebNotificationTray::HidePopups() {
+ DCHECK(popup_collection_.get());
+
+ popup_collection_->MarkAllPopupsShown();
+ popup_collection_.reset();
+}
bool WebNotificationTray::ShowMessageCenter() {
message_center_delegate_ =

Powered by Google App Engine
This is Rietveld 408576698