Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 99543003: Fix popup crash on ChromeOS. (Closed)

Created:
7 years ago by dewittj
Modified:
7 years ago
Reviewers:
stevenjb, Jun Mukai
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, tfarina
Visibility:
Public.

Description

Fix popup crash on ChromeOS. The popup collection was not handling correctly the case where it tells the message center to mark its popups read, causing a NOTREACHED in observer list. BUG=324142 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238515

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase + WS nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M ash/system/web_notification/web_notification_tray.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/message_center/web_notification_tray.cc View 1 chunk +6 lines, -1 line 0 comments Download
M ui/message_center/message_center_tray.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M ui/message_center/views/message_popup_collection.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/message_center/views/message_popup_collection.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dewittj
7 years ago (2013-12-02 18:27:53 UTC) #1
Jun Mukai
lgtm. Just curious, what about cocoa?
7 years ago (2013-12-02 21:10:13 UTC) #2
dewittj
Cocoa should be fine, since the only cross-platform part was just changed a few revs ...
7 years ago (2013-12-02 22:56:28 UTC) #3
sadrul
sadrul@ -> stevenjb@, since he is more familiar with web-notifications than I.
7 years ago (2013-12-02 23:19:09 UTC) #4
stevenjb
lgtm https://codereview.chromium.org/99543003/diff/1/ui/message_center/message_center_tray.cc File ui/message_center/message_center_tray.cc (right): https://codereview.chromium.org/99543003/diff/1/ui/message_center/message_center_tray.cc#newcode107 ui/message_center/message_center_tray.cc:107: nit: Extra WS line here?
7 years ago (2013-12-02 23:26:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/99543003/20001
7 years ago (2013-12-03 18:23:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/99543003/20001
7 years ago (2013-12-03 19:19:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/99543003/20001
7 years ago (2013-12-03 23:50:40 UTC) #8
commit-bot: I haz the power
7 years ago (2013-12-04 01:12:06 UTC) #9
Message was sent while issue was closed. 
Change committed as 238515

Powered by Google App Engine
This is Rietveld 408576698