Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issue 995343002: Integrate iOS specific changes in the core domdistiller.js (Closed)

Created:
5 years, 9 months ago by noyau (Ping after 24h)
Modified:
5 years, 9 months ago
Reviewers:
nyquist, cjhopman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Integrate iOS specific changes in the core domdistiller.js The file in iOS was just a modified copy and diverged over time. Moved the if from the grd file to the core js file in order to allow for easier maintenance. BUG=None Committed: https://crrev.com/43a2b8170db29bda0ca11411b8a231ea2b47947b Cr-Commit-Position: refs/heads/master@{#320321}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -31 lines) Patch
M components/dom_distiller/core/javascript/domdistiller.js View 2 chunks +16 lines, -1 line 0 comments Download
D components/dom_distiller/ios/javascript/domdistiller.js View 1 chunk +0 lines, -24 lines 0 comments Download
M components/resources/dom_distiller_resources.grdp View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
noyau (Ping after 24h)
5 years, 9 months ago (2015-03-11 12:26:04 UTC) #4
nyquist
Could you please do this in the dom-distiller repo instead? That would be more better.
5 years, 9 months ago (2015-03-12 00:34:52 UTC) #5
noyau (Ping after 24h)
On 2015/03/12 00:34:52, nyquist wrote: > Could you please do this in the dom-distiller repo ...
5 years, 9 months ago (2015-03-12 09:02:00 UTC) #6
nyquist
okay, let's do this as the first step to consolidate these two approaches in the ...
5 years, 9 months ago (2015-03-12 16:56:22 UTC) #7
nyquist
lgtm
5 years, 9 months ago (2015-03-12 16:56:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995343002/40001
5 years, 9 months ago (2015-03-12 16:58:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 9 months ago (2015-03-12 18:13:47 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 18:14:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43a2b8170db29bda0ca11411b8a231ea2b47947b
Cr-Commit-Position: refs/heads/master@{#320321}

Powered by Google App Engine
This is Rietveld 408576698