[SVG] Implement 'discard' element

Source/core/svg/SVGDiscardElement.h

+/*
+ * Copyright (C) 2013 Samsung Electronics. All rights reserved.

[Inactive, 2014/01/11 16:31:26]

2014?

[pavane, 2014/01/11 17:14:18]

I liked it. :)
Done.

+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ *     * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef SVGDiscardElement_h
+#define SVGDiscardElement_h
+
+#include "core/svg/animation/SVGSMILElement.h"
+
+namespace WebCore {
+
+class SVGDiscardElement FINAL : public SVGSMILElement {
+public:
+    static PassRefPtr<SVGDiscardElement> create(Document&);
+
+    virtual bool isSVGDiscardElement() const OVERRIDE FINAL { return true; }

[Inactive, 2014/01/11 16:31:26]

No need for FINAL as the class is already FINAL

[pavane, 2014/01/11 17:14:18]

Done.

+private:
+    explicit SVGDiscardElement(Document&);
+
+    virtual bool isAdditive() const { return false; }

[Inactive, 2014/01/11 16:31:26]

You're missing quite a lot of OVERRIDE

[pavane, 2014/01/11 17:14:18]

Done.

+    virtual void resetAnimatedType() { }
+    virtual void clearAnimatedType(SVGElement* targetElement) { }
+    virtual void applyResultsToTarget() { }
+    virtual bool hasValidAttributeType();
+    virtual bool hasValidAttributeName() OVERRIDE;
+    virtual void animationAttributeChanged() { }
+
+    virtual void startedActiveInterval() { }
+    virtual void updateAnimation(float percent, unsigned repeat, SVGSMILElement* resultElement) { }
+};
+
+} // namespace WebCore
+
+#endif // SVGDiscardElement_h