Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 995313003: Moving the initialization of AtExitManager to base::android::Init() (Closed)

Created:
5 years, 9 months ago by michaelbai
Modified:
5 years, 9 months ago
Reviewers:
nyquist
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moving the initialization of AtExitManager to base::android::Init(), it shouldn't be part of JNI registration, So the embedded which doesn't require to register JNI methods (like WebView) could still work properly. BUG=464008 Committed: https://crrev.com/f40324b8e160c353366b03492051f0a8eae90dcb Cr-Commit-Position: refs/heads/master@{#320166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M base/android/base_jni_onload.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/android/library_loader/library_loader_hooks.h View 1 chunk +4 lines, -0 lines 0 comments Download
M base/android/library_loader/library_loader_hooks.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
michaelbai
5 years, 9 months ago (2015-03-11 20:24:55 UTC) #2
nyquist
lgtm, but could you split up the CL description? It's a very long line. I ...
5 years, 9 months ago (2015-03-11 20:27:37 UTC) #3
michaelbai
done, in cq
5 years, 9 months ago (2015-03-11 20:43:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995313003/1
5 years, 9 months ago (2015-03-11 20:44:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-11 22:20:44 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 22:21:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f40324b8e160c353366b03492051f0a8eae90dcb
Cr-Commit-Position: refs/heads/master@{#320166}

Powered by Google App Engine
This is Rietveld 408576698