Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: chrome/renderer/extensions/webstore_bindings.cc

Issue 995283004: Move Extension ScriptContext creation into ScriptContextSet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Ready Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/webstore_bindings.cc
diff --git a/chrome/renderer/extensions/webstore_bindings.cc b/chrome/renderer/extensions/webstore_bindings.cc
index c46a23cb4ee56d6cf310b19f509f9387d933eb78..876f736ba773be7528187fe5f06764f75b7a77e6 100644
--- a/chrome/renderer/extensions/webstore_bindings.cc
+++ b/chrome/renderer/extensions/webstore_bindings.cc
@@ -14,6 +14,7 @@
#include "extensions/renderer/script_context.h"
#include "third_party/WebKit/public/web/WebDocument.h"
#include "third_party/WebKit/public/web/WebElement.h"
+#include "third_party/WebKit/public/web/WebLocalFrame.h"
#include "third_party/WebKit/public/web/WebNode.h"
#include "third_party/WebKit/public/web/WebNodeList.h"
#include "third_party/WebKit/public/web/WebUserGestureIndicator.h"
@@ -22,7 +23,6 @@
using blink::WebDocument;
using blink::WebElement;
-using blink::WebFrame;
using blink::WebNode;
using blink::WebNodeList;
using blink::WebUserGestureIndicator;
@@ -79,7 +79,7 @@ void WebstoreBindings::Install(
std::string webstore_item_id;
std::string error;
- WebFrame* frame = context()->web_frame();
+ blink::WebLocalFrame* frame = context()->web_frame();
if (!GetWebstoreItemIdFromFrame(
frame, preferred_store_link_url, &webstore_item_id, &error)) {
@@ -102,8 +102,10 @@ void WebstoreBindings::Install(
// static
bool WebstoreBindings::GetWebstoreItemIdFromFrame(
- WebFrame* frame, const std::string& preferred_store_link_url,
- std::string* webstore_item_id, std::string* error) {
+ blink::WebLocalFrame* frame,
+ const std::string& preferred_store_link_url,
+ std::string* webstore_item_id,
+ std::string* error) {
if (frame != frame->top()) {
*error = kNotInTopFrameError;
return false;

Powered by Google App Engine
This is Rietveld 408576698