extensions/renderer/document_custom_bindings.cc - Issue 995283004: Move Extension ScriptContext creation into ScriptContextSet.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/renderer/document_custom_bindings.cc

Issue 995283004: Move Extension ScriptContext creation into ScriptContextSet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix memory for real Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « extensions/renderer/dispatcher.cc ('k') | extensions/renderer/request_sender.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "extensions/renderer/document_custom_bindings.h"	5 #include "extensions/renderer/document_custom_bindings.h"

6	6

7 #include <string>	7 #include <string>

8	8

9 #include "base/bind.h"	9 #include "base/bind.h"

10 #include "extensions/renderer/script_context.h"	10 #include "extensions/renderer/script_context.h"

11 #include "third_party/WebKit/public/web/WebDocument.h"	11 #include "third_party/WebKit/public/web/WebDocument.h"

12 #include "third_party/WebKit/public/web/WebFrame.h"	12 #include "third_party/WebKit/public/web/WebLocalFrame.h"

13 #include "v8/include/v8.h"	13 #include "v8/include/v8.h"

14	14

15 namespace extensions {	15 namespace extensions {

16	16

17 DocumentCustomBindings::DocumentCustomBindings(ScriptContext* context)	17 DocumentCustomBindings::DocumentCustomBindings(ScriptContext* context)

18 : ObjectBackedNativeHandler(context) {	18 : ObjectBackedNativeHandler(context) {

19 RouteFunction("RegisterElement",	19 RouteFunction("RegisterElement",

20 base::Bind(&DocumentCustomBindings::RegisterElement,	20 base::Bind(&DocumentCustomBindings::RegisterElement,

21 base::Unretained(this)));	21 base::Unretained(this)));

22 }	22 }

(...skipping 10 matching lines...) Expand all Loading...
33 v8::Local<v8::Object> options = v8::Local<v8::Object>::Cast(args[1]);	33 v8::Local<v8::Object> options = v8::Local<v8::Object>::Cast(args[1]);

34	34

35 blink::WebExceptionCode ec = 0;	35 blink::WebExceptionCode ec = 0;

36 blink::WebDocument document = context()->web_frame()->document();	36 blink::WebDocument document = context()->web_frame()->document();

37 v8::Handle<v8::Value> constructor = document.registerEmbedderCustomElement(	37 v8::Handle<v8::Value> constructor = document.registerEmbedderCustomElement(

38 blink::WebString::fromUTF8(element_name), options, ec);	38 blink::WebString::fromUTF8(element_name), options, ec);

39 args.GetReturnValue().Set(constructor);	39 args.GetReturnValue().Set(constructor);

40 }	40 }

41	41

42 } // namespace extensions	42 } // namespace extensions

OLD	NEW