Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 995283002: Files.app: Remove console.error from expected error case. (Closed)

Created:
5 years, 9 months ago by fukino
Modified:
5 years, 9 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Remove console.error from expected error case. Failure to get metadata from content metadata is within expectation, and it is handled properly, so let me remove the console.error for it. BUG=none Committed: https://crrev.com/7da50d030e6d949e9574b68e6280c0d3e0edeb71 Cr-Commit-Position: refs/heads/master@{#320066}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
fukino
PTAL. Thanks!
5 years, 9 months ago (2015-03-11 09:08:35 UTC) #2
hirono
On 2015/03/11 09:08:35, fukino wrote: > PTAL. Thanks! lgtm!
5 years, 9 months ago (2015-03-11 09:15:07 UTC) #3
fukino
On 2015/03/11 09:15:07, hirono wrote: > On 2015/03/11 09:08:35, fukino wrote: > > PTAL. Thanks! ...
5 years, 9 months ago (2015-03-11 09:32:17 UTC) #4
fukino
On 2015/03/11 09:15:07, hirono wrote: > On 2015/03/11 09:08:35, fukino wrote: > > PTAL. Thanks! ...
5 years, 9 months ago (2015-03-11 09:32:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995283002/1
5 years, 9 months ago (2015-03-11 09:32:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-11 10:07:33 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 10:08:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7da50d030e6d949e9574b68e6280c0d3e0edeb71
Cr-Commit-Position: refs/heads/master@{#320066}

Powered by Google App Engine
This is Rietveld 408576698