Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 995253002: Web Animations: Split image slice interpolation out of LengthBoxStyleInterpolation (Closed)

Created:
5 years, 9 months ago by alancutter (OOO until 2018)
Modified:
5 years, 9 months ago
CC:
dstockwell, darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-style_chromium.org, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Web Animations: Split image slice interpolation out of LengthBoxStyleInterpolation This change rewrites the image slice animation handling done by LengthBoxStyleInterpolation as a separate class called ImageSliceStyleInterpolation. The old code was crashing on numbers in debug and had little reason for mixing image slices and clip rects in the same class. BUG=466007 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191767

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Total comments: 1

Patch Set 5 : Review changes #

Patch Set 6 : Logic fail fix #

Patch Set 7 : Rebase #

Patch Set 8 : Public member for Windows #

Patch Set 9 : Clean up #

Patch Set 10 : Windows aftngns #

Patch Set 11 : crbug.com/466536 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -157 lines) Patch
M LayoutTests/animations/interpolation/border-image-slice-interpolation.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +43 lines, -7 lines 0 comments Download
M LayoutTests/animations/interpolation/border-image-slice-interpolation-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +42 lines, -14 lines 0 comments Download
A Source/core/animation/ImageSliceStyleInterpolation.h View 1 2 3 4 5 6 7 8 1 chunk +40 lines, -0 lines 0 comments Download
A Source/core/animation/ImageSliceStyleInterpolation.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +99 lines, -0 lines 0 comments Download
M Source/core/animation/LengthBoxStyleInterpolation.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/animation/LengthBoxStyleInterpolation.cpp View 1 2 chunks +4 lines, -38 lines 0 comments Download
M Source/core/animation/LengthBoxStyleInterpolationTest.cpp View 2 chunks +0 lines, -90 lines 0 comments Download
M Source/core/animation/StringKeyframe.cpp View 1 2 3 4 5 6 3 chunks +13 lines, -3 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 36 (18 generated)
alancutter (OOO until 2018)
5 years, 9 months ago (2015-03-11 05:26:33 UTC) #2
dstockwell
https://codereview.chromium.org/995253002/diff/40001/Source/core/animation/ImageSliceStyleInterpolation.cpp File Source/core/animation/ImageSliceStyleInterpolation.cpp (right): https://codereview.chromium.org/995253002/diff/40001/Source/core/animation/ImageSliceStyleInterpolation.cpp#newcode54 Source/core/animation/ImageSliceStyleInterpolation.cpp:54: || quad.left()->isPercentage() == isPercentage did you mean && ?
5 years, 9 months ago (2015-03-11 05:33:27 UTC) #4
Eric Willigers
https://codereview.chromium.org/995253002/diff/60001/Source/core/animation/ImageSliceStyleInterpolation.cpp File Source/core/animation/ImageSliceStyleInterpolation.cpp (right): https://codereview.chromium.org/995253002/diff/60001/Source/core/animation/ImageSliceStyleInterpolation.cpp#newcode54 Source/core/animation/ImageSliceStyleInterpolation.cpp:54: || quad.left()->isPercentage() == isPercentage &&
5 years, 9 months ago (2015-03-11 05:38:09 UTC) #5
alancutter (OOO until 2018)
https://codereview.chromium.org/995253002/diff/40001/Source/core/animation/ImageSliceStyleInterpolation.cpp File Source/core/animation/ImageSliceStyleInterpolation.cpp (right): https://codereview.chromium.org/995253002/diff/40001/Source/core/animation/ImageSliceStyleInterpolation.cpp#newcode54 Source/core/animation/ImageSliceStyleInterpolation.cpp:54: || quad.left()->isPercentage() == isPercentage On 2015/03/11 05:33:26, dstockwell wrote: ...
5 years, 9 months ago (2015-03-11 05:42:42 UTC) #6
Eric Willigers
lgtm
5 years, 9 months ago (2015-03-11 05:46:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995253002/100001
5 years, 9 months ago (2015-03-11 05:46:59 UTC) #9
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-11 05:47:01 UTC) #11
dstockwell
lgtm
5 years, 9 months ago (2015-03-11 05:55:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995253002/100001
5 years, 9 months ago (2015-03-11 05:55:50 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_dbg/builds/31044)
5 years, 9 months ago (2015-03-11 06:00:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995253002/120001
5 years, 9 months ago (2015-03-11 09:18:33 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/builds/38911)
5 years, 9 months ago (2015-03-11 10:20:03 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995253002/160001
5 years, 9 months ago (2015-03-11 12:49:51 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/builds/38935)
5 years, 9 months ago (2015-03-11 13:44:49 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995253002/160001
5 years, 9 months ago (2015-03-12 00:04:00 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995253002/180001
5 years, 9 months ago (2015-03-12 02:57:08 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995253002/200001
5 years, 9 months ago (2015-03-12 08:45:54 UTC) #35
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 11:58:29 UTC) #36
Message was sent while issue was closed. 
Committed patchset #11 (id:200001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191767

Powered by Google App Engine
This is Rietveld 408576698