Move DumpProcessWithoutCrash to base, so we can use it from net and content

base/debug/dump_without_crashing.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/debug/dump_without_crashing.h"
+
+#include "base/logging.h"
+
+namespace {
+
+// Pointer to the function that's called by DumpWithoutCrashing() to dump the
+// process's memory.
+#if defined(OS_POSIX)
+void (*dump_without_crashing_function_)() = NULL;
+#elif defined(OS_WIN)
+void (__cdecl *dump_without_crashing_function_)() = NULL;

[Mark Mentovai, 2013/12/17 20:12:09]

All of these #ifdefs just for __cdecl. It’d read much more cleanly if you had
some MACRO you could use to specify the calling convention attribute. Even
better, maybe all you really need is a typedef inside an #ifdef, and you can
eschew the macro grossness altogether.

+#endif
+
+}  // namespace
+
+namespace base {
+
+namespace debug {
+
+void DumpWithoutCrashing() {
+#if defined(OS_WIN) || defined(OS_POSIX)
+  if (dump_without_crashing_function_)
+    (*dump_without_crashing_function_)();
+#else
+  NOTIMPLEMENTED();
+#endif
+}
+
+#if defined(OS_POSIX)
+void SetDumpWithoutCrashingFunction(void (*function)()) {
+  dump_without_crashing_function_ = function;
+}
+#elif defined(OS_WIN)
+void SetDumpWithoutCrashingFunction(void (__cdecl *function)()) {
+  dump_without_crashing_function_ = function;
+}
+#endif
+
+}  // namespace debug
+
+}  // namespace base