Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 995103002: Fix video_decode_accelerator_unittest build on non-CrOS (Closed)

Created:
5 years, 9 months ago by vignatti (out of this project)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, stevenjb+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix video_decode_accelerator_unittest build on non-CrOS When running this unittest in non-CrOS systems, DisplayConfigurator configure_display_ needs to be initialized as true as well, so the Native Display will actually be created properly at ::Init time. BUG=none TEST=video_decode_accelerator_unittest --vmodule=*/ui/ozone/platform/drm/*=3, and check the Ozone DRM informational messages that creates the display Committed: https://crrev.com/ac25812351c8753b68176cf2595912738c26e4b8 Cr-Commit-Position: refs/heads/master@{#320120}

Patch Set 1 #

Total comments: 2

Patch Set 2 : s/ChromeOS/Chrome OS/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M content/common/gpu/media/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/media/rendering_helper.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/display/chromeos/display_configurator.h View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
vignatti (out of this project)
posciak@: content/common/gpu/media/DEPS content/common/gpu/media/rendering_helper.cc derat@ ui/display/chromeos/display_configurator.h PTAL.
5 years, 9 months ago (2015-03-10 19:40:04 UTC) #4
Daniel Erat
lgtm for ui/display/chromeos/display_configurator.h https://codereview.chromium.org/995103002/diff/1/ui/display/chromeos/display_configurator.h File ui/display/chromeos/display_configurator.h (right): https://codereview.chromium.org/995103002/diff/1/ui/display/chromeos/display_configurator.h#newcode359 ui/display/chromeos/display_configurator.h:359: // be enabled. If we aren't ...
5 years, 9 months ago (2015-03-10 19:42:15 UTC) #5
vignatti (out of this project)
https://codereview.chromium.org/995103002/diff/1/ui/display/chromeos/display_configurator.h File ui/display/chromeos/display_configurator.h (right): https://codereview.chromium.org/995103002/diff/1/ui/display/chromeos/display_configurator.h#newcode359 ui/display/chromeos/display_configurator.h:359: // be enabled. If we aren't running on ChromeOS, ...
5 years, 9 months ago (2015-03-10 19:45:47 UTC) #6
Pawel Osciak
content/common/gpu/media lgtm
5 years, 9 months ago (2015-03-11 12:36:50 UTC) #7
Pawel Osciak
On 2015/03/11 12:36:50, Pawel Osciak wrote: > content/common/gpu/media lgtm By the way, the CL description ...
5 years, 9 months ago (2015-03-11 12:38:18 UTC) #8
vignatti (out of this project)
On 2015/03/11 12:38:18, Pawel Osciak wrote: > On 2015/03/11 12:36:50, Pawel Osciak wrote: > > ...
5 years, 9 months ago (2015-03-11 18:06:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995103002/40001
5 years, 9 months ago (2015-03-11 18:07:19 UTC) #12
dnicoara
On 2015/03/11 18:06:09, vignatti wrote: > On 2015/03/11 12:38:18, Pawel Osciak wrote: > > On ...
5 years, 9 months ago (2015-03-11 18:09:13 UTC) #13
oshima
just fyi: video_decode_accelerator_unittest is not covered by CQ bots right now. see crbug.com/461437
5 years, 9 months ago (2015-03-11 18:13:51 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 9 months ago (2015-03-11 19:44:57 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 19:46:14 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ac25812351c8753b68176cf2595912738c26e4b8
Cr-Commit-Position: refs/heads/master@{#320120}

Powered by Google App Engine
This is Rietveld 408576698