Issue 995033002: Don't recurse in LengthStyleInterpolation helper constructCalcExpression

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 995033002: Don't recurse in LengthStyleInterpolation helper constructCalcExpression (Closed)

Created:
5 years, 9 months ago by fs

Modified:
5 years, 9 months ago

Reviewers:
dstockwell, alancutter (OOO until 2018)

CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-style_chromium.org, dstockwell, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Don't recurse in LengthStyleInterpolation helper constructCalcExpression The mixed for-loop and recursion made this helper function look more complicated than it needed to be. Make it iterate only using the for-loop. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191696

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -14 lines)			Patch
	M	Source/core/animation/LengthStyleInterpolation.cpp	View		2 chunks	+13 lines, -14 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Just something I noticed in passing - not sure if you're wedded to the current ...

5 years, 9 months ago (2015-03-10 17:11:28 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995033002/1

5 years, 9 months ago (2015-03-11 09:51:22 UTC) #6

commit-bot: I haz the power

5 years, 9 months ago (2015-03-11 12:39:22 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191696

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages