Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 995013005: Simplify pending message script handling. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix hardcoded constant. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/assembler.cc ('k') | src/full-codegen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc
index 5e5721e9db92dca7c7107a092eed6175e178027e..97353b522eaf29124fd70b67ab5e4c17466cdae8 100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -1266,8 +1266,6 @@ void AstGraphBuilder::VisitTryFinallyStatement(TryFinallyStatement* stmt) {
ExternalReference::address_of_pending_message_obj(isolate());
ExternalReference message_present =
ExternalReference::address_of_has_pending_message(isolate());
- ExternalReference message_script =
- ExternalReference::address_of_pending_message_script(isolate());
// We keep a record of all paths that enter the finally-block to be able to
// dispatch to the correct continuation point after the statements in the
@@ -1305,7 +1303,6 @@ void AstGraphBuilder::VisitTryFinallyStatement(TryFinallyStatement* stmt) {
environment()->Push(result);
environment()->Push(BuildLoadExternal(message_object, kMachAnyTagged));
environment()->Push(BuildLoadExternal(message_present, kMachBool));
- environment()->Push(BuildLoadExternal(message_script, kMachAnyTagged));
// Evaluate the finally-block.
Visit(stmt->finally_block());
@@ -1313,7 +1310,6 @@ void AstGraphBuilder::VisitTryFinallyStatement(TryFinallyStatement* stmt) {
// The result value, dispatch token and message is restored from the operand
// stack (this is in sync with FullCodeGenerator::ExitFinallyBlock).
- BuildStoreExternal(message_script, kMachAnyTagged, environment()->Pop());
BuildStoreExternal(message_present, kMachBool, environment()->Pop());
BuildStoreExternal(message_object, kMachAnyTagged, environment()->Pop());
result = environment()->Pop();
« no previous file with comments | « src/assembler.cc ('k') | src/full-codegen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698