Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 995013005: Simplify pending message script handling. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix hardcoded constant. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen.h ('k') | src/isolate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 5236 matching lines...) Expand 10 before | Expand all | Expand 10 after
5247 ExternalReference pending_message_obj = 5247 ExternalReference pending_message_obj =
5248 ExternalReference::address_of_pending_message_obj(isolate()); 5248 ExternalReference::address_of_pending_message_obj(isolate());
5249 __ mov(edx, Operand::StaticVariable(pending_message_obj)); 5249 __ mov(edx, Operand::StaticVariable(pending_message_obj));
5250 __ push(edx); 5250 __ push(edx);
5251 5251
5252 ExternalReference has_pending_message = 5252 ExternalReference has_pending_message =
5253 ExternalReference::address_of_has_pending_message(isolate()); 5253 ExternalReference::address_of_has_pending_message(isolate());
5254 __ mov(edx, Operand::StaticVariable(has_pending_message)); 5254 __ mov(edx, Operand::StaticVariable(has_pending_message));
5255 __ SmiTag(edx); 5255 __ SmiTag(edx);
5256 __ push(edx); 5256 __ push(edx);
5257
5258 ExternalReference pending_message_script =
5259 ExternalReference::address_of_pending_message_script(isolate());
5260 __ mov(edx, Operand::StaticVariable(pending_message_script));
5261 __ push(edx);
5262 } 5257 }
5263 5258
5264 5259
5265 void FullCodeGenerator::ExitFinallyBlock() { 5260 void FullCodeGenerator::ExitFinallyBlock() {
5266 DCHECK(!result_register().is(edx)); 5261 DCHECK(!result_register().is(edx));
5267 // Restore pending message from stack. 5262 // Restore pending message from stack.
5268 __ pop(edx); 5263 __ pop(edx);
5269 ExternalReference pending_message_script =
5270 ExternalReference::address_of_pending_message_script(isolate());
5271 __ mov(Operand::StaticVariable(pending_message_script), edx);
5272
5273 __ pop(edx);
5274 __ SmiUntag(edx); 5264 __ SmiUntag(edx);
5275 ExternalReference has_pending_message = 5265 ExternalReference has_pending_message =
5276 ExternalReference::address_of_has_pending_message(isolate()); 5266 ExternalReference::address_of_has_pending_message(isolate());
5277 __ mov(Operand::StaticVariable(has_pending_message), edx); 5267 __ mov(Operand::StaticVariable(has_pending_message), edx);
5278 5268
5279 __ pop(edx); 5269 __ pop(edx);
5280 ExternalReference pending_message_obj = 5270 ExternalReference pending_message_obj =
5281 ExternalReference::address_of_pending_message_obj(isolate()); 5271 ExternalReference::address_of_pending_message_obj(isolate());
5282 __ mov(Operand::StaticVariable(pending_message_obj), edx); 5272 __ mov(Operand::StaticVariable(pending_message_obj), edx);
5283 5273
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
5395 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5385 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5396 Assembler::target_address_at(call_target_address, 5386 Assembler::target_address_at(call_target_address,
5397 unoptimized_code)); 5387 unoptimized_code));
5398 return OSR_AFTER_STACK_CHECK; 5388 return OSR_AFTER_STACK_CHECK;
5399 } 5389 }
5400 5390
5401 5391
5402 } } // namespace v8::internal 5392 } } // namespace v8::internal
5403 5393
5404 #endif // V8_TARGET_ARCH_IA32 5394 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/full-codegen.h ('k') | src/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698