net/http/http_stream_factory_impl.cc - Issue 995013004: Add IsAlternativeServiceBroken(), remove is_broken.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl.cc

Issue 995013004: Add IsAlternativeServiceBroken(), remove is_broken. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More nits. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_stream_factory_impl.cc

diff --git a/net/http/http_stream_factory_impl.cc b/net/http/http_stream_factory_impl.cc

index 235122d2e834ae363f77203bc88277c5ad2c96e5..250771c5e1ef764b25f6d6e435664b4eb30e26c8 100644

--- a/net/http/http_stream_factory_impl.cc

+++ b/net/http/http_stream_factory_impl.cc

@@ -190,7 +190,9 @@ AlternateProtocolInfo HttpStreamFactoryImpl::GetAlternateProtocolRequestFor(

if (alternate.protocol == UNINITIALIZED_ALTERNATE_PROTOCOL)

return kNoAlternateProtocol;

- if (alternate.is_broken) {

+ const AlternativeService alternative_service(alternate.protocol,

+ origin.host(), alternate.port);

+ if (http_server_properties.IsAlternativeServiceBroken(alternative_service)) {

HistogramAlternateProtocolUsage(ALTERNATE_PROTOCOL_USAGE_BROKEN);

return kNoAlternateProtocol;

}