net/http/http_server_properties_manager.h - Issue 995013004: Add IsAlternativeServiceBroken(), remove is_broken.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_server_properties_manager.h

Issue 995013004: Add IsAlternativeServiceBroken(), remove is_broken. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More nits. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_server_properties_manager.h

diff --git a/net/http/http_server_properties_manager.h b/net/http/http_server_properties_manager.h

index b71671a5cccd975803f3c77982cd588d91441885..c22b9ecde1afebda91ae133fe9ff59abf9d1ebad 100644

--- a/net/http/http_server_properties_manager.h

+++ b/net/http/http_server_properties_manager.h

@@ -93,6 +93,8 @@ class NET_EXPORT HttpServerPropertiesManager : public HttpServerProperties {

AlternateProtocol alternate_protocol,

double alternate_probability) override;

void SetBrokenAlternateProtocol(const HostPortPair& server) override;

+ bool IsAlternativeServiceBroken(

+ const AlternativeService& alternative_service) override;

bool WasAlternateProtocolRecentlyBroken(const HostPortPair& server) override;

void ConfirmAlternateProtocol(const HostPortPair& server) override;

void ClearAlternateProtocol(const HostPortPair& server) override;

@@ -195,6 +197,7 @@ class NET_EXPORT HttpServerPropertiesManager : public HttpServerProperties {

void SaveSpdySettingsToServerPrefs(const SettingsMap* spdy_settings_map,

base::DictionaryValue* server_pref_dict);

void SaveAlternateProtocolToServerPrefs(

+ const HostPortPair& origin,

const AlternateProtocolInfo* port_alternate_protocol,

base::DictionaryValue* server_pref_dict);

void SaveNetworkStatsToServerPrefs(