Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: net/http/http_server_properties.h

Issue 995013004: Add IsAlternativeServiceBroken(), remove is_broken. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More nits. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_server_properties.h
diff --git a/net/http/http_server_properties.h b/net/http/http_server_properties.h
index e8796cb752c7d9e833d522a53d40b09d6fe604ef..a27cf806c4a833123a1be06e35d92f40d43f4e75 100644
--- a/net/http/http_server_properties.h
+++ b/net/http/http_server_properties.h
@@ -120,27 +120,12 @@ struct NET_EXPORT AlternativeService {
struct NET_EXPORT AlternateProtocolInfo {
AlternateProtocolInfo()
- : port(0),
- protocol(UNINITIALIZED_ALTERNATE_PROTOCOL),
- probability(0),
- is_broken(false) {}
+ : port(0), protocol(UNINITIALIZED_ALTERNATE_PROTOCOL), probability(0) {}
AlternateProtocolInfo(uint16 port,
AlternateProtocol protocol,
double probability)
- : port(port),
- protocol(protocol),
- probability(probability),
- is_broken(false) {}
-
- AlternateProtocolInfo(uint16 port,
- AlternateProtocol protocol,
- double probability,
- bool is_broken)
- : port(port),
- protocol(protocol),
- probability(probability),
- is_broken(is_broken) {}
+ : port(port), protocol(protocol), probability(probability) {}
bool Equals(const AlternateProtocolInfo& other) const {
return port == other.port &&
@@ -153,7 +138,6 @@ struct NET_EXPORT AlternateProtocolInfo {
uint16 port;
AlternateProtocol protocol;
double probability;
- bool is_broken;
};
struct NET_EXPORT SupportsQuic {
@@ -237,6 +221,10 @@ class NET_EXPORT HttpServerProperties {
// Sets the Alternate-Protocol for |server| to be BROKEN.
virtual void SetBrokenAlternateProtocol(const HostPortPair& server) = 0;
+ // Returns true iff |alternative_service| is currently broken.
+ virtual bool IsAlternativeServiceBroken(
+ const AlternativeService& alternative_service) = 0;
+
// Returns true if Alternate-Protocol for |server| was recently BROKEN.
virtual bool WasAlternateProtocolRecentlyBroken(
const HostPortPair& server) = 0;

Powered by Google App Engine
This is Rietveld 408576698