Telemetry: Filter by label in addition to page URL.

Telemetry: Filter by label in addition to page URL.

This adds label filtering (in addition to existing URL 
filtering). Extracting different filter types from a single
command-line-flag was either more complicated to parse or
less expressive, so this adds new command-lines for these
filters.

BUG=324031
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239664

[epenner, 2013-12-07 01:06:36]

Ptal. Just whipped this up and wanted to make sure this is approx what you were
suggesting regarding label filters.

I haven't tried this yet. Are labels from .json pagesets automatically
transferred to the 'page' objects in python?

[epenner, 2013-12-07 02:10:35]

It appears the JSON attrs are getting applied to the page indeed.

Just tested this by adding "PageUsesFastPath" : true, and then filtering by that
label.

[nduca, 2013-12-09 19:41:46]

can you think up a unit test for this? page_runner_unittest might have somethign
you can crib from.

[nduca, 2013-12-09 19:41:50]

https://codereview.chromium.org/99493004/diff/40001/tools/telemetry/telemetry...
File tools/telemetry/telemetry/page/page_filter.py (right):

https://codereview.chromium.org/99493004/diff/40001/tools/telemetry/telemetry...
tools/telemetry/telemetry/page/page_filter.py:66:
group.add_option('--label-filter', dest='label_filter',
can you do label -> page_label throughout? or something that clarifies that the
label is on a page.

[nduca, 2013-12-09 19:42:07]

lgtm assuming you can get a unittest etc

[epennerAtGoogle, 2013-12-09 20:14:02]

https://codereview.chromium.org/99493004/diff/40001/tools/telemetry/telemetry...
File tools/telemetry/telemetry/page/page_filter.py (right):

https://codereview.chromium.org/99493004/diff/40001/tools/telemetry/telemetry...
tools/telemetry/telemetry/page/page_filter.py:66:
group.add_option('--label-filter', dest='label_filter',
On 2013/12/09 19:41:51, nduca wrote:
> can you do label -> page_label throughout? or something that clarifies that
the
> label is on a page.

I'm assuming you mean page-label-filter. Okay I'll change when I add a test.

[epenner, 2013-12-10 02:14:06]

Tested both include/exclude code in page_filter_unittest

One minor change is that I now check that the label also evaluates to 'true'.
Eg. specifying "my_label : False" doesn't trigger the filter.

[commit-bot: I haz the power, 2013-12-10 02:14:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/epenner@chromium.org/99493004/80001

[commit-bot: I haz the power, 2013-12-10 05:16:23]

Change committed as 239664