Restore stress_test_common script.

Restore stress_test_common script.

This script were present in https://codereview.chromium.org/22935012
but it disappeared when that CL was commited manually.
Also fix copy-paste error in analyze_stress_test.

TEST= courgette/run_stress_test -s <chrome_dir1> <chrome_dir2> <result_dir>
      courgette/run_mem_test <result_dir>
      courgette/analyze_stress_test <result_dir>/log
      courgette/analyze_mem_test <result_dir>
Also create fake bsdiff and bspatch which use courgette executable and
add courgette and these utilities to the PATH.
BUG=274054
R=dgarrett@chromium.org

Committed: https://crrev.com/7b636e95c3096f34fc1d15bbb8227983e412b9ec
Cr-Commit-Position: refs/heads/master@{#320250}

[halyavin2, 2015-03-10 08:47:32]

Since your last commit is last year, let me know if you think I should direct
this review to wfh@ instead.

[dgarrett, 2015-03-10 17:43:15]

I think it's best to direct to wfh now.

On Tue, Mar 10, 2015 at 1:47 AM <halyavin@chromium.org> wrote:

> Reviewers: dgarrett,
>
> Message:
> Since your last commit is last year, let me know if you think I should
> direct
> this review to wfh@ instead.
>
> Description:
> Restore stress_test_common script.
>
> This script were present in https://codereview.chromium.org/22935012
> but it disappeared when that CL was commited manually.
> Also fix copy-paste error in analyze_stress_test.
>
> TEST= courgette/run_stress_test -s <chrome_dir1> <chrome_dir2> <result_dir>
>        courgette/run_mem_test <result_dir>
>        courgette/analyze_stress_test <result_dir>/log
>        courgette/analyze_mem_test <result_dir>
> Also create fake bsdiff and bspatch which use courgette executable and
> add courgette and these utilities to the PATH.
> BUG= none
> R=dgarrett@chromium.org
>
> Please review this at https://codereview.chromium.org/994883002/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+17, -1 lines):
>    M courgette/analyze_stress_test
>    A courgette/stress_test_common
>
>
> Index: courgette/analyze_stress_test
> diff --git a/courgette/analyze_stress_test b/courgette/analyze_stress_test
> index
> 0c700eba59a638b6556a30fab79fbd5d2d2430a6..6d2ffd91b00128d74dd2f3a0d7f403
> d3dd7a87c6
> 100755
> --- a/courgette/analyze_stress_test
> +++ b/courgette/analyze_stress_test
> @@ -53,7 +53,7 @@ $(count_result "FAIL_DISASSEMBLE") failed to
> disassemble/assemble
>   $(count_result "PASS_BSDIFF") succesful bsdiff patches
>   $(count_result "FAIL_BSDIFF") failed bsdiff patches
>   $(count_result "BEST_COURGETTE") patch(es) where courgette is smaller
> (bz2)
> -$(count_result "BEST_BSDIFF") patch(es) where bsdiff is smaller (xz)
> +$(count_result "BEST_BSDIFF") patch(es) where bsdiff is smaller (bz2)
>   $(count_result "BEST_TIE") patch(es) where both are the same size (bz2)
>   $(count_result "XZBEST_COURGETTE") patch(es) where courgette (xz) is
> smaller
>   $(count_result "XZBEST_BSDIFF") patch(es) where bsdiff is smaller (xz)
> Index: courgette/stress_test_common
> diff --git a/courgette/stress_test_common b/courgette/stress_test_common
> new file mode 100755
> index
> 0000000000000000000000000000000000000000..b6c9b25e8886567cda17bba240ef73
> 37a3cce611
> --- /dev/null
> +++ b/courgette/stress_test_common
> @@ -0,0 +1,16 @@
> +#!/bin/bash
> +
> +# Emit an error message
> +error() {
> +  echo "error: ${@}" >&2
> +}
> +
> +# Given a token, search for and count the instances of lines from the
> +# logfile that start with the token.
> +count_result() {
> +  if [ ! -z "${1}" ]; then
> +    echo $(cat "${log}" | grep "^${1} " | wc -l)
> +  else
> +    echo 0
> +  fi
> +}
> \ No newline at end of file
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[halyavin2, 2015-03-10 17:51:31]

halyavin@chromium.org changed reviewers:
+ wfh@chromium.org

[halyavin2, 2015-03-10 17:51:32]

Ok, +wfh@.

[Will Harris, 2015-03-11 20:14:11]

On 2015/03/10 17:51:32, halyavin2 wrote:
> Ok, +wfh@.

what is the bug here - is it still 274054?

[halyavin2, 2015-03-11 20:27:44]

On 2015/03/11 at 20:14:11, wfh wrote:
> On 2015/03/10 17:51:32, halyavin2 wrote:
> > Ok, +wfh@.
> 
> what is the bug here - is it still 274054?

The bug is to make these scripts work. They reference non-existing script now.

[Will Harris, 2015-03-11 20:43:49]

On 2015/03/11 20:27:44, halyavin2 wrote:
> On 2015/03/11 at 20:14:11, wfh wrote:
> > On 2015/03/10 17:51:32, halyavin2 wrote:
> > > Ok, +wfh@.
> > 
> > what is the bug here - is it still 274054?
> 
> The bug is to make these scripts work. They reference non-existing script now.

can you update the CL description to reflect the bug?

[Will Harris, 2015-03-11 23:54:59]

lgtm

[halyavin2, 2015-03-12 08:12:01]

The CQ bit was checked by halyavin@chromium.org

[commit-bot: I haz the power, 2015-03-12 08:12:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/994883002/1

[commit-bot: I haz the power, 2015-03-12 08:34:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-12 08:35:05]

Patchset 1 (id:??) landed as
https://crrev.com/7b636e95c3096f34fc1d15bbb8227983e412b9ec
Cr-Commit-Position: refs/heads/master@{#320250}