Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Issue 99483007: [telemetry] Ensure page sets reference the right WPR archives. (Closed)

Created:
7 years ago by dtu
Modified:
7 years ago
Reviewers:
nduca, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[telemetry] Ensure page sets reference the right WPR archives. There are some page sets that point to the old src-internal tools/perf/data dir. Also remove the back-pointer from the archive info file to the page set file. It's unused and confusing when the page set is generated by a script instead. Slight behavior modification: new archives are now named based on the archive info file instead of the page set. BUG=223667 TEST=tools/telemetry/run_tests PageSetArchiveInfo Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238903

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -96 lines) Patch
M tools/perf/benchmarks/jsgamebench.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/kraken.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/robohornet_pro.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/data/2012Q3.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/browsermark.json View 1 chunk +1 line, -2 lines 0 comments Download
M tools/perf/page_sets/data/calendar_forward_backward.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/canvasmark.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/gmail_alt_threadlist_conversation.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/gmail_alt_two_labels.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/gmail_expand_collapse_conversation.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/html5gaming.json View 1 chunk +1 line, -2 lines 0 comments Download
M tools/perf/page_sets/data/intl_ar_fa_he.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/intl_es_fr_pt-BR.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/intl_hi_ru.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/intl_ja_zh.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/intl_ko_th_vi.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/jsgamebench.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/key_desktop_sites.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/key_mobile_sites.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/key_silk_cases.json View 2 chunks +1 line, -2 lines 0 comments Download
M tools/perf/page_sets/data/kraken.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/maps.json View 1 chunk +1 line, -2 lines 0 comments Download
M tools/perf/page_sets/data/octane.json View 1 chunk +1 line, -2 lines 0 comments Download
M tools/perf/page_sets/data/peacekeeper_array.json View 2 chunks +1 line, -2 lines 0 comments Download
M tools/perf/page_sets/data/peacekeeper_dom.json View 2 chunks +1 line, -2 lines 0 comments Download
M tools/perf/page_sets/data/peacekeeper_experimental.json View 2 chunks +1 line, -2 lines 0 comments Download
M tools/perf/page_sets/data/peacekeeper_html5.json View 2 chunks +1 line, -2 lines 0 comments Download
M tools/perf/page_sets/data/peacekeeper_render.json View 2 chunks +1 line, -2 lines 0 comments Download
M tools/perf/page_sets/data/peacekeeper_string.json View 2 chunks +1 line, -2 lines 0 comments Download
M tools/perf/page_sets/data/pica.json View 1 chunk +1 line, -2 lines 0 comments Download
M tools/perf/page_sets/data/plus_alt_posts_photos.json View 1 chunk +0 lines, -1 line 0 comments Download
A + tools/perf/page_sets/data/robohornet_pro.json View 1 chunk +1 line, -2 lines 0 comments Download
A + tools/perf/page_sets/data/robohornet_pro_000.wpr.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/perf/page_sets/data/robohornetpro.json View 1 chunk +0 lines, -9 lines 0 comments Download
D tools/perf/page_sets/data/robohornetpro_000.wpr.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/scirra.json View 2 chunks +1 line, -2 lines 0 comments Download
M tools/perf/page_sets/data/sunspider.json View 1 chunk +1 line, -2 lines 0 comments Download
M tools/perf/page_sets/data/test.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/top_10.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/top_10_mobile.json View 2 chunks +1 line, -2 lines 0 comments Download
M tools/perf/page_sets/data/top_25.json View 2 chunks +1 line, -2 lines 0 comments Download
M tools/perf/page_sets/data/tough_canvas_cases.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/tough_layout_cases.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/typical_25.json View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/tough_memory_multi_tab.json View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/page_set.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_set_archive_info.py View 4 chunks +11 lines, -17 lines 0 comments Download
M tools/telemetry/telemetry/page/page_set_archive_info_unittest.py View 5 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dtu
7 years ago (2013-12-04 22:13:52 UTC) #1
tonyg
lgtm wicked
7 years ago (2013-12-04 23:25:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/99483007/1
7 years ago (2013-12-04 23:38:50 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-05 05:50:04 UTC) #4
Message was sent while issue was closed.
Change committed as 238903

Powered by Google App Engine
This is Rietveld 408576698