[cr tool] Adding the run command

[cr tool] Adding the run command

BUG=316397
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238352

[Andrew Hayden (chromium.org), 2013-12-02 16:47:49]

lgtm

[bulach, 2013-12-02 18:30:20]

lgtm, thanks!

https://codereview.chromium.org/99483002/diff/1/tools/cr/cr/commands/run.py
File tools/cr/cr/commands/run.py (right):

https://codereview.chromium.org/99483002/diff/1/tools/cr/cr/commands/run.py#n...
tools/cr/cr/commands/run.py:34: test_targets = [target for target in targets if
target.is_test]
nit: I've seen some people prefer this for simple list expansions:

filter(lambda t: t.is_test, targets)

either way is fine by me, although the filter is slightly more compact..

[ian_cottrell, 2013-12-02 18:40:15]

On 2013/12/02 18:30:20, bulach wrote:
> lgtm, thanks!
> 
> https://codereview.chromium.org/99483002/diff/1/tools/cr/cr/commands/run.py
> File tools/cr/cr/commands/run.py (right):
> 
>
https://codereview.chromium.org/99483002/diff/1/tools/cr/cr/commands/run.py#n...
> tools/cr/cr/commands/run.py:34: test_targets = [target for target in targets
if
> target.is_test]
> nit: I've seen some people prefer this for simple list expansions:
> 
> filter(lambda t: t.is_test, targets)
> 
> either way is fine by me, although the filter is slightly more compact..

Guido says use list comprehensions :-)
Also, the filter is only more compact because you used t not target..

test_targets = [t for t in targets if t.is_test]
test_targets = filter(lambda t: t.is_test, targets)

[commit-bot: I haz the power, 2013-12-02 22:41:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iancottrell@chromium.org/99483002/1

[commit-bot: I haz the power, 2013-12-03 00:56:49]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-12-03 10:43:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/iancottrell@chromium.org/99483002/1

[commit-bot: I haz the power, 2013-12-03 11:39:03]

Change committed as 238352