Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 994823004: [iOS] Upstream //ios/net (Closed)

Created:
5 years, 9 months ago by droger
Modified:
5 years, 9 months ago
Reviewers:
sdefresne, mmenke
CC:
chromium-reviews, erikwright (departed), cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Upstream //ios/net This CL upstream the iOS-specific glue between Chrome network stack and the system APIs (such as web views, cookie store). The intent is to move this code to //net/ios eventually. Committed: https://crrev.com/476922e0321f5d051afa33b84a3e901b05915778 Cr-Commit-Position: refs/heads/master@{#319910}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4260 lines, --1 lines) Patch
M ios/ios.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A + ios/net/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A ios/net/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A ios/net/clients/crn_forwarding_network_client.h View 1 chunk +21 lines, -0 lines 0 comments Download
A ios/net/clients/crn_forwarding_network_client.mm View 1 chunk +87 lines, -0 lines 0 comments Download
A ios/net/clients/crn_forwarding_network_client_factory.h View 1 chunk +82 lines, -0 lines 1 comment Download
A ios/net/clients/crn_forwarding_network_client_factory.mm View 1 chunk +102 lines, -0 lines 0 comments Download
A ios/net/clients/crn_forwarding_network_client_factory_unittest.mm View 1 chunk +220 lines, -0 lines 0 comments Download
A ios/net/clients/crn_network_client_protocol.h View 1 chunk +87 lines, -0 lines 0 comments Download
A ios/net/clients/crn_simple_network_client_factory.h View 1 chunk +24 lines, -0 lines 0 comments Download
A ios/net/clients/crn_simple_network_client_factory.mm View 1 chunk +34 lines, -0 lines 0 comments Download
A ios/net/cookies/cookie_cache.h View 1 chunk +78 lines, -0 lines 0 comments Download
A ios/net/cookies/cookie_cache.cc View 1 chunk +82 lines, -0 lines 0 comments Download
A ios/net/cookies/cookie_cache_unittest.cc View 1 chunk +168 lines, -0 lines 0 comments Download
A ios/net/cookies/cookie_creation_time_manager.h View 1 chunk +49 lines, -0 lines 0 comments Download
A ios/net/cookies/cookie_creation_time_manager.mm View 1 chunk +120 lines, -0 lines 0 comments Download
A ios/net/cookies/cookie_creation_time_manager_unittest.mm View 1 chunk +126 lines, -0 lines 0 comments Download
A ios/net/cookies/cookie_store_ios_client.h View 1 chunk +43 lines, -0 lines 0 comments Download
A ios/net/cookies/cookie_store_ios_client.mm View 1 chunk +35 lines, -0 lines 0 comments Download
A ios/net/cookies/system_cookie_util.h View 1 chunk +44 lines, -0 lines 0 comments Download
A ios/net/cookies/system_cookie_util.mm View 1 chunk +153 lines, -0 lines 0 comments Download
A ios/net/cookies/system_cookie_util_unittest.mm View 1 chunk +136 lines, -0 lines 0 comments Download
A ios/net/crn_http_protocol_handler.h View 1 chunk +43 lines, -0 lines 0 comments Download
A ios/net/crn_http_protocol_handler.mm View 1 chunk +952 lines, -0 lines 0 comments Download
A ios/net/crn_http_protocol_handler_proxy.h View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/net/crn_http_protocol_handler_proxy_with_client_thread.h View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/net/crn_http_protocol_handler_proxy_with_client_thread.mm View 1 chunk +201 lines, -0 lines 0 comments Download
A ios/net/crn_http_url_response.h View 1 chunk +17 lines, -0 lines 0 comments Download
A ios/net/crn_http_url_response.mm View 1 chunk +34 lines, -0 lines 0 comments Download
A ios/net/http_protocol_logging.h View 1 chunk +21 lines, -0 lines 0 comments Download
A ios/net/http_protocol_logging.mm View 1 chunk +77 lines, -0 lines 0 comments Download
A ios/net/ios_net.gyp View 1 chunk +56 lines, -0 lines 0 comments Download
A ios/net/ios_net_unittests.gyp View 1 chunk +34 lines, -0 lines 0 comments Download
A ios/net/nsurlrequest_util.h View 1 chunk +19 lines, -0 lines 0 comments Download
A ios/net/nsurlrequest_util.mm View 1 chunk +22 lines, -0 lines 0 comments Download
A ios/net/nsurlrequest_util_unittest.mm View 1 chunk +47 lines, -0 lines 0 comments Download
A ios/net/protocol_handler_util.h View 1 chunk +37 lines, -0 lines 0 comments Download
A ios/net/protocol_handler_util.mm View 1 chunk +213 lines, -0 lines 0 comments Download
A ios/net/protocol_handler_util_unittest.mm View 1 chunk +274 lines, -0 lines 0 comments Download
A ios/net/request_tracker.h View 1 chunk +172 lines, -0 lines 0 comments Download
A ios/net/request_tracker.mm View 1 chunk +220 lines, -0 lines 0 comments Download
A ios/net/url_scheme_util.h View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/net/url_scheme_util.mm View 1 chunk +26 lines, -0 lines 0 comments Download
A ios/net/url_scheme_util_unittest.mm View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
droger
5 years, 9 months ago (2015-03-10 16:57:18 UTC) #3
sdefresne
rs lgtm https://codereview.chromium.org/994823004/diff/20001/ios/net/clients/crn_forwarding_network_client_factory.h File ios/net/clients/crn_forwarding_network_client_factory.h (right): https://codereview.chromium.org/994823004/diff/20001/ios/net/clients/crn_forwarding_network_client_factory.h#newcode29 ios/net/clients/crn_forwarding_network_client_factory.h:29: // TODO(marq): Investigate possible less bloated interfaces ...
5 years, 9 months ago (2015-03-10 17:00:45 UTC) #4
droger
+ mmenke for the dependency on net in ios/net/DEPS
5 years, 9 months ago (2015-03-10 17:06:28 UTC) #6
mmenke
On 2015/03/10 17:06:28, droger wrote: > + mmenke for the dependency on net in ios/net/DEPS ...
5 years, 9 months ago (2015-03-10 17:08:44 UTC) #7
droger
Thanks for the reviews.
5 years, 9 months ago (2015-03-10 17:09:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/994823004/20001
5 years, 9 months ago (2015-03-10 17:10:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 9 months ago (2015-03-10 17:18:17 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 17:20:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/476922e0321f5d051afa33b84a3e901b05915778
Cr-Commit-Position: refs/heads/master@{#319910}

Powered by Google App Engine
This is Rietveld 408576698