Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9000)

Unified Diff: chrome/installer/mini_installer.gyp

Issue 99473012: Enable icu_use_data_file on Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased again Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/mini_installer.gyp
diff --git a/chrome/installer/mini_installer.gyp b/chrome/installer/mini_installer.gyp
index 385c93028cad58a4bbc43251272855170de616ef..9a2dcfef8ceefc40583cafbfcfc1a0a04146f33c 100644
--- a/chrome/installer/mini_installer.gyp
+++ b/chrome/installer/mini_installer.gyp
@@ -223,6 +223,15 @@
'target_arch_flag': '--target_arch=x86',
},
}],
+ ['icu_use_data_file_flag == 0', {
+ 'inputs': [
+ '<(PRODUCT_DIR)/icudt.dll',
+ ],
+ }, { # else icu_use_data_file_flag == 1
Mark Mentovai 2014/01/17 19:03:59 technically != 0
jungshik at Google 2014/01/17 19:50:40 Done.
+ 'inputs': [
+ '<(PRODUCT_DIR)/icudtl.dat',
+ ],
+ }],
],
'inputs': [
'<(create_installer_archive_py_path)',
@@ -233,7 +242,6 @@
'<(PRODUCT_DIR)/nacl_irt_x86_32.nexe',
'<(PRODUCT_DIR)/nacl_irt_x86_64.nexe',
'<(PRODUCT_DIR)/locales/en-US.pak',
- '<(PRODUCT_DIR)/icudt.dll',
],
'outputs': [
# Also note that chrome.packed.7z is defined as an output in a

Powered by Google App Engine
This is Rietveld 408576698