Enable icu_use_data_file on Windows

base/i18n/icu_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/i18n/icu_util.h"
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #endif
 
 #include <string>
 
 #include "base/files/file_path.h"
 #include "base/files/memory_mapped_file.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "base/strings/string_util.h"
 #include "base/strings/sys_string_conversions.h"
+#if defined(OS_WIN)
+#include "base/strings/utf_string_conversions.h"
+#endif
 #include "third_party/icu/source/common/unicode/putil.h"
 #include "third_party/icu/source/common/unicode/udata.h"
 
 #if defined(OS_MACOSX)
 #include "base/mac/foundation_util.h"
 #endif
 
 #define ICU_UTIL_DATA_FILE   0
 #define ICU_UTIL_DATA_SHARED 1
 #define ICU_UTIL_DATA_STATIC 2
@@ skipping 66 matching lines @@
     data_path = data_path.AppendASCII(ICU_UTIL_DATA_FILE_NAME);
 #else
     FilePath data_path =
       base::mac::PathForFrameworkBundleResource(CFSTR(ICU_UTIL_DATA_FILE_NAME));
     if (data_path.empty()) {
       DLOG(ERROR) << ICU_UTIL_DATA_FILE_NAME << " not found in bundle";
       return false;
     }
 #endif  // OS check
     if (!mapped_file.Initialize(data_path)) {
+#if defined(OS_WIN)
+      DLOG(ERROR) << "Couldn't mmap " << base::UTF16ToUTF8(data_path.value());

[Mark Mentovai, 2013/12/17 22:12:02]

You can do this on all platforms, getting rid of the OS #ifdef and the new
#include at the top of the file:

  data_path.AsUTF8Unsafe().value()

Or, since this is just a DLOG, you can get rid of the filename altogether and
just have it say "Couldn't mmap ICU data". That’s fine too, and none of the
other DLOGs in this function try to print data_path even when they know it and
it’s relevant.

[jungshik at Google, 2013/12/18 20:59:11]

Thanks. I went with AsUTF8Unsafe. 

+#else
       DLOG(ERROR) << "Couldn't mmap " << data_path.value();
+#endif
       return false;
     }
   }
   UErrorCode err = U_ZERO_ERROR;
   udata_setCommonData(const_cast<uint8*>(mapped_file.data()), &err);
   return err == U_ZERO_ERROR;
 #endif
 }
 
 }  // namespace i18n
 }  // namespace base