Enable icu_use_data_file on Windows

base/base.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
   },
   'includes': [
     '../build/win_precompile.gypi',
@@ skipping 683 matching lines @@
         'base_i18n',
         'base_message_loop_tests',
         'base_prefs',
         'base_prefs_test_support',
         'base_static',
         'run_all_unittests',
         'test_support_base',
         'third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
         '../testing/gmock.gyp:gmock',
         '../testing/gtest.gyp:gtest',
+        '../third_party/icu/icu.gyp:icuuc',

[Mark Mentovai, 2013/12/17 22:12:02]

Why are you moving this? Seems like a no-op change that’s less sorted than it
was before.

If the order really is relevant, (1) I’d be surprised and (2) it definitely
needs explanation.

[jungshik at Google, 2013/12/18 20:59:11]

Sorry to get you 'alarmed'. That's just an accidental change. I'll revert. 

         '../third_party/icu/icu.gyp:icui18n',
-        '../third_party/icu/icu.gyp:icuuc',
       ],
       'includes': ['../build/nocompile.gypi'],
       'variables': {
          # TODO(ajwong): Is there a way to autodetect this?
         'module_dir': 'base'
       },
       'conditions': [
         ['desktop_linux == 1 or chromeos == 1', {
           'defines': [
             'USE_SYMBOLIZE',
@@ skipping 72 matching lines @@
             'message_loop/message_pump_glib_unittest.cc',
           ]
         }],
         ['OS == "linux" and linux_use_tcmalloc==1', {
             'dependencies': [
               'allocator/allocator.gyp:allocator',
             ],
           },
         ],
         ['OS == "win"', {
           # This is needed to trigger the dll copy step on windows.

[Mark Mentovai, 2013/12/17 22:12:02]

Move the comment into the condition it applies to.

[jungshik at Google, 2013/12/18 20:59:11]

Done.

           # TODO(mark): This should not be necessary.
-          'dependencies': [
-            '../third_party/icu/icu.gyp:icudata',
+          'conditions': [
+            ['icu_use_data_file_flag==0', {
+              'dependencies': [
+                '../third_party/icu/icu.gyp:icudata',
+              ],
+            }],
           ],
           'sources!': [
             'file_descriptor_shuffle_unittest.cc',
             'files/dir_reader_posix_unittest.cc',
             'threading/worker_pool_posix_unittest.cc',
             'message_loop/message_pump_libevent_unittest.cc',
           ],
           # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
           'msvs_disabled_warnings': [
             4267,
@@ skipping 588 matching lines @@
             'base_unittests.isolate',
           ],
           'sources': [
             'base_unittests.isolate',
           ],
         },
       ],
     }],
   ],
 }