chrome/tools/build/win/server.rules - Issue 99473012: Enable icu_use_data_file on Windows

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/tools/build/win/server.rules

Issue 99473012: Enable icu_use_data_file on Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: icudtl.dat listed in win/server.rules Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <VisualStudioToolFile	2 <VisualStudioToolFile

3 Name="DLL Registration Rules"	3 Name="DLL Registration Rules"

4 Version="8.00"	4 Version="8.00"

5 >	5 >

6 <Rules>	6 <Rules>

7 <CustomBuildRule	7 <CustomBuildRule

8 Name="Scan Server DLLs"	8 Name="Scan Server DLLs"

9 DisplayName="Scan Server DLLs"	9 DisplayName="Scan Server DLLs"

10 CommandLine="$(SolutionDir)..\third_party\python_24\pyth on.exe $(SolutionDir)tools\build\win\scan_server_dlls.py --output_dir="$(Ou tDir)" --input_file="$(InputPath)" --header_output_dir="$(In tDir)" --distribution=$(CHROMIUM_BUILD)"	10 CommandLine="$(SolutionDir)..\third_party\python_24\pyth on.exe $(SolutionDir)tools\build\win\scan_server_dlls.py --output_dir="$(Ou tDir)" --input_file="$(InputPath)" --header_output_dir="$(In tDir)" --distribution=$(CHROMIUM_BUILD)"

11 Outputs="$(OutDir)/registered_dlls.h;"	11 Outputs="$(OutDir)/registered_dlls.h;"

12 » » » AdditionalDependencies="$(SolutionDir)\tools\build\win\s can_server_dlls.py;$(OutDir)\chrome.exe;$(OutDir)\crash_reporter.exe;$(OutDir)\c hrome.dll;$(OutDir)\locales\en-US.dll;$(OutDir)\icudt.dll"	12 » » » AdditionalDependencies="$(SolutionDir)\tools\build\win\s can_server_dlls.py;$(OutDir)\chrome.exe;$(OutDir)\crash_reporter.exe;$(OutDir)\c hrome.dll;$(OutDir)\locales\en-US.dll;$(OutDir)\icudtl.dat"
	jungshik at Google 2013/12/20 12:05:58 Looks like I shouldn't add icudtl.dat here because Looks like I shouldn't add icudtl.dat here because it's not a dll. Can I leave this file alone even when icudt.dll is not present any more (when icu_use_data_file_flag is set to 1) or should I remove icudt.dll?
13 FileExtensions="*.release"	13 FileExtensions="*.release"

14 ExecutionDescription="Scanning for COM Server DLLs..."	14 ExecutionDescription="Scanning for COM Server DLLs..."

15 ShowOnlyRuleProperties="false"	15 ShowOnlyRuleProperties="false"

16 >	16 >

17 <Properties>	17 <Properties>

18 </Properties>	18 </Properties>

19 </CustomBuildRule>	19 </CustomBuildRule>

20 </Rules>	20 </Rules>

21 </VisualStudioToolFile>	21 </VisualStudioToolFile>

OLD	NEW

« no previous file with comments | « chrome/tools/build/win/TESTS ('k') | net/net.gyp » ('j') | no next file with comments »