Issue 99473007: Mojo: Add a Mojo-specific multiprocess test base class.

Issue 99473007: Mojo: Add a Mojo-specific multiprocess test base class. (Closed)

Created:
7 years ago by viettrungluu

Modified:
7 years ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Add a Mojo-specific multiprocess test base class. This sets up (most of) the infrastructure that'll be needed to set up a PlatformChannel between parent and child processes. R=darin@chromium.org, darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238425

Patch Set 1 #

Patch Set 2 : oops #

Patch Set 3 : rebased #

Total comments: 2

Patch Set 4 : comment + win fix #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+216 lines, -10 lines)			Patch
A	mojo/common/test/multiprocess_test_base.h	View	1 2 3	1 chunk	+69 lines, -0 lines	0 comments	Download
A	mojo/common/test/multiprocess_test_base.cc	View	1 2 3	1 chunk	+104 lines, -0 lines	0 comments	Download
A	mojo/common/test/multiprocess_test_base_unittest.cc	View		1 chunk	+29 lines, -0 lines	0 comments	Download
M	mojo/mojo.gyp	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	mojo/system/platform_channel.h	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	mojo/system/platform_channel_posix.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

LGTM https://codereview.chromium.org/99473007/diff/40001/mojo/common/test/multiprocess_test_base.h File mojo/common/test/multiprocess_test_base.h (right): https://codereview.chromium.org/99473007/diff/40001/mojo/common/test/multiprocess_test_base.h#newcode31 mojo/common/test/multiprocess_test_base.h:31: // Wait for the child process to terminate. ...

7 years ago (2013-12-03 00:33:05 UTC) #2

viettrungluu

Thanks. https://codereview.chromium.org/99473007/diff/40001/mojo/common/test/multiprocess_test_base.h File mojo/common/test/multiprocess_test_base.h (right): https://codereview.chromium.org/99473007/diff/40001/mojo/common/test/multiprocess_test_base.h#newcode31 mojo/common/test/multiprocess_test_base.h:31: // Wait for the child process to terminate. ...

7 years ago (2013-12-03 01:10:43 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/99473007/60001

7 years ago (2013-12-03 01:28:48 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=230970

7 years ago (2013-12-03 04:19:06 UTC) #5

viettrungluu

7 years ago (2013-12-03 17:48:55 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r238425 (presubmit successful).

Expand Messages | Collapse Messages