Rename page filter options to story options.

Rename page filter options to story options.
Refactor code and tests.

--page-filter is kept as a (deprecated) alternative to --story-filter.

BUG=444425
Committed: https://crrev.com/e1ec81835a29dcd89010e957813d649d4af048a7
Cr-Commit-Position: refs/heads/master@{#321226}

[slamm, 2015-03-09 23:47:53]

Rename "user story" to "story". Fix a label filter case.

[slamm, 2015-03-10 00:15:57]

Add regex error test. Tidy up.

[slamm, 2015-03-10 00:19:28]

Add regex error test. Tidy up.

[slamm, 2015-03-10 00:19:46]

Patchset #3 (id:40001) has been deleted

[slamm, 2015-03-10 00:20:41]

slamm@chromium.org changed reviewers:
+ aiolos@chromium.org, dtu@chromium.org

[aiolos (Not reviewing), 2015-03-10 00:39:56]

https://codereview.chromium.org/994683003/diff/60001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/user_story/user_story_filter.py (right):

https://codereview.chromium.org/994683003/diff/60001/tools/telemetry/telemetr...
tools/telemetry/telemetry/user_story/user_story_filter.py:52: help='Deprecated.
Use --story-filter instead.')
My first thought is that we should be consistent here, and either keep all of
the deprecated flags, or get rid of all of them. Did you keep a deprecated
--page-filter flag, but not the other ones, because you only found usage of that
flag in the Codebase?

[slamm, 2015-03-10 00:42:22]

On 2015/03/10 00:39:56, aiolos wrote:
>
https://codereview.chromium.org/994683003/diff/60001/tools/telemetry/telemetr...
> File tools/telemetry/telemetry/user_story/user_story_filter.py (right):
> 
>
https://codereview.chromium.org/994683003/diff/60001/tools/telemetry/telemetr...
> tools/telemetry/telemetry/user_story/user_story_filter.py:52:
help='Deprecated.
> Use --story-filter instead.')
> My first thought is that we should be consistent here, and either keep all of
> the deprecated flags, or get rid of all of them. Did you keep a deprecated
> --page-filter flag, but not the other ones, because you only found usage of
that
> flag in the Codebase?

Yes. I only found --page-filter in the Chromium code base.
BTW, I added a comment to the bug that a proper fix includes updating docs (if
any) and code references (later CL).

[aiolos (Not reviewing), 2015-03-10 20:08:08]

https://codereview.chromium.org/994683003/diff/60001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/user_story/user_story_filter_unittest.py (right):

https://codereview.chromium.org/994683003/diff/60001/tools/telemetry/telemetr...
tools/telemetry/telemetry/user_story/user_story_filter_unittest.py:7: from
telemetry.page import page as page_module
optional nit: Don't use import as unless you have a conflict.

[sullivan, 2015-03-10 20:12:11]

sullivan@chromium.org changed reviewers:
+ sullivan@chromium.org

[sullivan, 2015-03-10 20:12:12]

lgtm

lgtm w/aiolos's nit

[dtu, 2015-03-10 20:52:00]

https://codereview.chromium.org/994683003/diff/60001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/user_story/user_story_filter.py (right):

https://codereview.chromium.org/994683003/diff/60001/tools/telemetry/telemetr...
tools/telemetry/telemetry/user_story/user_story_filter.py:53:
group.add_option('--story-exclude',
--story-filter-exclude

Actually, do we need this? Does anyone use this? Same with labels.

[slamm, 2015-03-17 18:23:45]

https://codereview.chromium.org/994683003/diff/60001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/user_story/user_story_filter.py (right):

https://codereview.chromium.org/994683003/diff/60001/tools/telemetry/telemetr...
tools/telemetry/telemetry/user_story/user_story_filter.py:53:
group.add_option('--story-exclude',
On 2015/03/10 20:51:59, dtu wrote:
> --story-filter-exclude
> 
> Actually, do we need this? Does anyone use this? Same with labels.

There is a mention of --page-filter-exclude in the following doc:

http://www.chromium.org/developers/telemetry/diagnosing-test-failures

I did not find any code references.

I am unsure if anyone filters by labels. The options did not turn up in Chromium
docs or code.

How about I check this in and then remove them in a follow-up CL? If someone
complains, then they can be added back easily.

https://codereview.chromium.org/994683003/diff/60001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/user_story/user_story_filter_unittest.py (right):

https://codereview.chromium.org/994683003/diff/60001/tools/telemetry/telemetr...
tools/telemetry/telemetry/user_story/user_story_filter_unittest.py:7: from
telemetry.page import page as page_module
On 2015/03/10 20:08:07, aiolos wrote:
> optional nit: Don't use import as unless you have a conflict.

Thanks for catching that. It applied to an earlier version I had.

[slamm, 2015-03-17 19:37:23]

On 2015/03/17 18:23:45, slamm wrote:
>
https://codereview.chromium.org/994683003/diff/60001/tools/telemetry/telemetr...
> File tools/telemetry/telemetry/user_story/user_story_filter.py (right):
> 
>
https://codereview.chromium.org/994683003/diff/60001/tools/telemetry/telemetr...
> tools/telemetry/telemetry/user_story/user_story_filter.py:53:
> group.add_option('--story-exclude',
> On 2015/03/10 20:51:59, dtu wrote:
> > --story-filter-exclude
> > 
> > Actually, do we need this? Does anyone use this? Same with labels.
> 
> There is a mention of --page-filter-exclude in the following doc:
> 
> http://www.chromium.org/developers/telemetry/diagnosing-test-failures
> 
> I did not find any code references.
> 
> I am unsure if anyone filters by labels. The options did not turn up in
Chromium
> docs or code.
> 
> How about I check this in and then remove them in a follow-up CL? If someone
> complains, then they can be added back easily.
> 
>
https://codereview.chromium.org/994683003/diff/60001/tools/telemetry/telemetr...
> File tools/telemetry/telemetry/user_story/user_story_filter_unittest.py
(right):
> 
>
https://codereview.chromium.org/994683003/diff/60001/tools/telemetry/telemetr...
> tools/telemetry/telemetry/user_story/user_story_filter_unittest.py:7: from
> telemetry.page import page as page_module
> On 2015/03/10 20:08:07, aiolos wrote:
> > optional nit: Don't use import as unless you have a conflict.
> 
> Thanks for catching that. It applied to an earlier version I had.

PTAL.

[aiolos (Not reviewing), 2015-03-17 19:52:43]

lgtm

https://codereview.chromium.org/994683003/diff/60001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/user_story/user_story_filter.py (right):

https://codereview.chromium.org/994683003/diff/60001/tools/telemetry/telemetr...
tools/telemetry/telemetry/user_story/user_story_filter.py:53:
group.add_option('--story-exclude',
On 2015/03/17 18:23:45, slamm wrote:
> On 2015/03/10 20:51:59, dtu wrote:
> > --story-filter-exclude
> > 
> > Actually, do we need this? Does anyone use this? Same with labels.
> 
> There is a mention of --page-filter-exclude in the following doc:
> 
> http://www.chromium.org/developers/telemetry/diagnosing-test-failures
> 
> I did not find any code references.
> 
> I am unsure if anyone filters by labels. The options did not turn up in
Chromium
> docs or code.
> 
> How about I check this in and then remove them in a follow-up CL? If someone
> complains, then they can be added back easily.

Very reasonable.

[slamm, 2015-03-17 21:12:34]

The CQ bit was checked by slamm@chromium.org

[slamm, 2015-03-17 21:12:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
sullivan@chromium.org
Link to the patchset: https://codereview.chromium.org/994683003/#ps80001 (title:
"fix nit.")

[commit-bot: I haz the power, 2015-03-17 21:13:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/994683003/80001

[commit-bot: I haz the power, 2015-03-18 01:04:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-18 01:04:18]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[slamm, 2015-03-18 17:15:02]

Fix word-o.

[slamm, 2015-03-18 17:15:47]

The CQ bit was checked by slamm@chromium.org

[slamm, 2015-03-18 17:15:48]

The patchset sent to the CQ was uploaded after l-g-t-m from aiolos@chromium.org,
sullivan@chromium.org
Link to the patchset: https://codereview.chromium.org/994683003/#ps100001
(title: "Fix word-o.")

[commit-bot: I haz the power, 2015-03-18 17:15:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/994683003/100001

[commit-bot: I haz the power, 2015-03-18 18:48:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-18 18:48:19]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[slamm, 2015-03-18 20:55:48]

Rename filter options in benchmarks.

[slamm, 2015-03-18 20:57:01]

The CQ bit was checked by slamm@chromium.org

[slamm, 2015-03-18 20:57:02]

The patchset sent to the CQ was uploaded after l-g-t-m from aiolos@chromium.org,
sullivan@chromium.org
Link to the patchset: https://codereview.chromium.org/994683003/#ps120001
(title: "Rename filter options in benchmarks.")

[commit-bot: I haz the power, 2015-03-18 20:57:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/994683003/120001

[slamm, 2015-03-18 21:39:58]

On 2015/03/18 20:57:42, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/994683003/120001

The trybot logs for patch 5 found that three benchmarks set the options
"page_label_filter" and "page_label_filter_exclude".
As a result, I will not submit a followup CL to remove the label-based filters.

[commit-bot: I haz the power, 2015-03-18 22:47:34]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2015-03-18 22:48:32]

Patchset 6 (id:??) landed as
https://crrev.com/e1ec81835a29dcd89010e957813d649d4af048a7
Cr-Commit-Position: refs/heads/master@{#321226}