Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 994663002: Slightly upgrade decideRoleFromSibling() in AXTableCell (Closed)

Created:
5 years, 9 months ago by k.czech
Modified:
5 years, 9 months ago
Reviewers:
dmazzoni
CC:
blink-reviews, nektarios, dmazzoni, je_julie(Not used), aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Slightly upgrade decideRoleFromSibling() in AXTableCell Make decideRoleFromSibling be more compact, that could handle both previous/next cells. Removed some redundant code. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192025

Patch Set 1 #

Patch Set 2 : Minor cleanup #

Total comments: 2

Patch Set 3 : Applied suggestions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M Source/modules/accessibility/AXTableCell.cpp View 1 2 2 chunks +16 lines, -18 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
k.czech
5 years, 9 months ago (2015-03-09 17:18:42 UTC) #2
k.czech
On 2015/03/09 17:18:42, k.czech wrote: Dominic any chance to look at this ?.
5 years, 9 months ago (2015-03-16 14:35:09 UTC) #3
dmazzoni
https://codereview.chromium.org/994663002/diff/20001/Source/modules/accessibility/AXTableCell.cpp File Source/modules/accessibility/AXTableCell.cpp (right): https://codereview.chromium.org/994663002/diff/20001/Source/modules/accessibility/AXTableCell.cpp#newcode111 Source/modules/accessibility/AXTableCell.cpp:111: static AccessibilityRole decideRoleFromSibling(LayoutTableCell* cell) I like naming the argument ...
5 years, 9 months ago (2015-03-16 15:12:16 UTC) #4
dmazzoni
lgtm
5 years, 9 months ago (2015-03-16 15:12:23 UTC) #5
k.czech
> https://codereview.chromium.org/994663002/diff/20001/Source/modules/accessibility/AXTableCell.cpp#newcode116 > Source/modules/accessibility/AXTableCell.cpp:116: if (Node* siblingNode = > cell->node()) { > I think you ...
5 years, 9 months ago (2015-03-17 16:00:30 UTC) #6
dmazzoni
lgtm
5 years, 9 months ago (2015-03-17 16:20:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/994663002/40001
5 years, 9 months ago (2015-03-17 16:20:15 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 17:51:47 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192025

Powered by Google App Engine
This is Rietveld 408576698