Add a --depfile flag that explicitly names the generated depfile.

Add a --depfile flag that explicitly names the generated depfile.

--depdir stays around, since the base directory of paths in the depfile needs
to be specified as well.

BUG=chromium:297672
r145

[Nico, 2013-12-31 23:00:41]

See https://codereview.chromium.org/25683011/#msg11
https://codereview.chromium.org/25683011/#msg12
https://codereview.chromium.org/25683011/#msg13 for the reasoning.

Since gyp runs actions from the directory of the .gyp file and not from the
build directory, it seems we need two flags :-/

(Also, I noticed that this puts the .d file as output in front of the ':' – this
works in deps mode, but in non-deps mode the output needs to be identical to the
first output listed in the ninja manifest. Maybe requiring deps mode is ok.)

[Nico, 2014-01-01 01:47:00]

(Oh, and grit_info --inputs outputs all the .py files that grit consists of
– should those be written to the generated depfile too?)

[Jói, 2014-01-02 10:45:12]

https://codereview.chromium.org/99463008/diff/1/grit/tool/build.py
File grit/tool/build.py (right):

https://codereview.chromium.org/99463008/diff/1/grit/tool/build.py#newcode122
grit/tool/build.py:122: elif key == '--depdir':
You're changing this flag from --dep-dir to --depdir; I'm assuming this is
intentional and that you intend to update Chrome's usage of the flag at the same
time as you roll the GRIT revision.

https://codereview.chromium.org/99463008/diff/1/grit/tool/build.py#newcode158
grit/tool/build.py:158: self.GenerateDepfile(opts.input, depfile, depdir)
Perhaps assert that if depfile is set, depdir is also set?

Alternatively I guess you could default depdir to the directory enclosing
depfile.

[Jói, 2014-01-02 10:45:38]

Also, I agree it would be more correct to also add all of GRIT's source files to
the depfile.

[koz (OOO until 15th September), 2014-01-05 23:21:58]

lgtm

Your reasoning makes sense and explicit is better than implicit :-)

https://codereview.chromium.org/99463008/diff/1/grit/tool/build.py
File grit/tool/build.py (right):

https://codereview.chromium.org/99463008/diff/1/grit/tool/build.py#newcode319
grit/tool/build.py:319: references to files relative to |depdir|. It will be put
in depfile.
nit: depfile -> |depfile|

[Nico, 2014-01-06 17:48:49]

Sorry about being slow to respond to comments.

https://codereview.chromium.org/99463008/diff/1/grit/tool/build.py
File grit/tool/build.py (right):

https://codereview.chromium.org/99463008/diff/1/grit/tool/build.py#newcode122
grit/tool/build.py:122: elif key == '--depdir':
On 2014/01/02 10:45:12, Jói wrote:
> You're changing this flag from --dep-dir to --depdir; I'm assuming this is
> intentional and that you intend to update Chrome's usage of the flag at the
same
> time as you roll the GRIT revision.

Yes, it's intentional (to match "depfile"). I think Chrome doesn't use this yet
so changing it should be safe.

https://codereview.chromium.org/99463008/diff/1/grit/tool/build.py#newcode158
grit/tool/build.py:158: self.GenerateDepfile(opts.input, depfile, depdir)
On 2014/01/02 10:45:12, Jói wrote:
> Perhaps assert that if depfile is set, depdir is also set?
> 
> Alternatively I guess you could default depdir to the directory enclosing
> depfile.

Changed this to `if depfile and depdir`

https://codereview.chromium.org/99463008/diff/1/grit/tool/build.py#newcode319
grit/tool/build.py:319: references to files relative to |depdir|. It will be put
in depfile.
On 2014/01/05 23:21:58, koz wrote:
> nit: depfile -> |depfile|

Done.

[Nico, 2014-01-08 00:58:55]

r145