Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 99463002: Libraries without '-l' treated as relative paths. (Closed)

Created:
7 years ago by bungeman-skia
Modified:
7 years ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Libraries without '-l' treated as relative paths. The following have the same effect on Windows: 'msvs_settings': { 'VCLinkerTool': { 'AdditionalDependencies': [ 'windowscodecs.lib', ],},}, 'link_settings': {'libraries': ['-lwindowscodecs.lib',],}, But this one is different: 'link_settings': {'libraries': ['windowscodecs.lib',],}, since this last one will attempt to find the library at third_party\skia\gyp\windowscodecs.lib or a place like this, instead of looking in the library paths. This also fixes capitalization of the affected libraries. R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=12434

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M gyp/images.gyp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/xps.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bungeman-skia
Brian, it looks like way back when you introduced the first of these, so putting ...
7 years ago (2013-12-02 16:52:50 UTC) #1
bsalomon
On 2013/12/02 16:52:50, bungeman1 wrote: > Brian, it looks like way back when you introduced ...
7 years ago (2013-12-02 19:49:01 UTC) #2
bungeman-skia
7 years ago (2013-12-02 19:54:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r12434 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698