Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 994583004: Revert of Set use_rndis_forwarder in platform backend. (Closed)

Created:
5 years, 9 months ago by nednguyen
Modified:
5 years, 9 months ago
Reviewers:
ariblue
CC:
chromium-reviews, telemetry-reviews_chromium.org, bengr, sclittle, bustamante, Zhen Wang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Set use_rndis_forwarder in platform backend. (patchset #2 id:20001 of https://codereview.chromium.org/860913003/) Reason for revert: Speculative revert for BUG=452080 Original issue's description: > Remove the android SetRndisForwarder() call from browser_backend and set it > directly in the platform_backend > > When the needs_browser_restart_after_each_page flag is set to true in the page > test, we initialize the browser_backend twice and call SetRndisForwarder() > twice. Instead, we can make this call for the platform once. > > Additionally, I added a simple unittest for the case when this flag is set. > > BUG=450331 > > Committed: https://crrev.com/d26579b485b0cb323af99487c524ac8ff751e2ef > Cr-Commit-Position: refs/heads/master@{#312882} TBR=ariblue@google.com BUG=450331

Patch Set 1 #

Messages

Total messages: 5 (2 generated)
nednguyen
Created Revert of Set use_rndis_forwarder in platform backend.
5 years, 9 months ago (2015-03-09 21:07:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/994583004/1
5 years, 9 months ago (2015-03-09 21:08:41 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 21:15:01 UTC) #5
Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

Powered by Google App Engine
This is Rietveld 408576698