Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: components/test/data/password_manager/automated_tests/tests.py

Issue 994573002: [Password manager tests automation] Add ability to run single test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test/data/password_manager/automated_tests/tests.py
diff --git a/components/test/data/password_manager/automated_tests/tests.py b/components/test/data/password_manager/automated_tests/tests.py
index 8bde955255f01555099b4083ce16755084318e61..e84ddaa538a353edf6b7e429fbcd150a877aeb06 100644
--- a/components/test/data/password_manager/automated_tests/tests.py
+++ b/components/test/data/password_manager/automated_tests/tests.py
@@ -257,67 +257,55 @@ class Vube(WebsiteTest):
self.Wait(1)
-def Tests(environment):
-
-
- # Working tests.
-
-
- environment.AddWebsiteTest(Facebook("facebook"))
-
- environment.AddWebsiteTest(Google("google"))
-
- environment.AddWebsiteTest(Linkedin("linkedin"))
-
- environment.AddWebsiteTest(Mailru("mailru"))
-
- environment.AddWebsiteTest(Nytimes("nytimes"))
-
- environment.AddWebsiteTest(Pinterest("pinterest"))
-
- environment.AddWebsiteTest(Reddit("reddit", username_not_auto=True))
-
- environment.AddWebsiteTest(Tumblr("tumblr", username_not_auto=True))
-
- environment.AddWebsiteTest(Twitter("twitter"))
-
- environment.AddWebsiteTest(Wikipedia("wikipedia", username_not_auto=True))
-
- environment.AddWebsiteTest(Yahoo("yahoo", username_not_auto=True))
-
- environment.AddWebsiteTest(Yandex("yandex"))
+def Tests(environment, tests_to_run=None):
+
+ # Working tests
vabr (Chromium) 2015/03/09 14:52:17 nit: The comment here and on line 278 is no longer
+ working_tests = {
+ "facebook": Facebook("facebook"),
+ "google": Google("google"),
+ "linkedin": Linkedin("linkedin"),
+ "mailru": Mailru("mailru"),
+ "nytimes": Nytimes("nytimes"),
+ "pinterest": Pinterest("pinterest"),
+ "reddit": Reddit("reddit", username_not_auto=True),
+ "tumblr": Tumblr("tumblr", username_not_auto=True),
+ "twitter": Twitter("twitter"),
+ "wikipedia": Wikipedia("wikipedia", username_not_auto=True),
+ "yahoo": Yahoo("yahoo", username_not_auto=True),
+ "yandex": Yandex("yandex")
+ }
# Disabled tests.
+ disabled_tests = {
+ "amazon": Amazon("amazon"), # Bug not reproducible without test.
+ "ask": Ask("ask"), # Password not saved.
+ "baidu": Baidu("baidu"), # Password not saved.
+ "cnn": Cnn("cnn"), # http://crbug.com/368690
+ "ebay": Ebay("ebay"), # http://crbug.com/368690
+ "espn": Espn("espn"), # Iframe, password saved but not autofileld.
+ "live": Live("live", username_not_auto=True), # http://crbug.com/367768
+ "163": One63("163"), # http://crbug.com/368690
+ "vube": Vube("vube"), # http://crbug.com/368690
+ }
+
+ if tests_to_run:
+ for test in tests_to_run:
+ if (test not in working_tests.keys() and
+ test not in disabled_tests.keys()):
+ print "Skip test: test {} is not in known tests".format(test)
+ continue
+ if test in working_tests.keys():
+ test_class = working_tests[test]
+ else:
+ test_class = disabled_tests[test]
+ environment.AddWebsiteTest(test_class)
+ else:
+ for _, test in working_tests:
+ environment.AddWebsiteTest(test)
+ for _, test in disabled_tests:
+ environment.AddWebsiteTest(test, disabled=True)
- # Bug not reproducible without test.
- environment.AddWebsiteTest(Amazon("amazon"), disabled=True)
-
- # Password not saved.
- environment.AddWebsiteTest(Ask("ask"), disabled=True)
-
- # Password not saved.
- environment.AddWebsiteTest(Baidu("baidu"), disabled=True)
-
- # http://crbug.com/368690
- environment.AddWebsiteTest(Cnn("cnn"), disabled=True)
-
- # http://crbug.com/368690
- environment.AddWebsiteTest(Ebay("ebay"), disabled=True)
-
- # Iframe, password saved but not autofileld.
- environment.AddWebsiteTest(Espn("espn"), disabled=True)
-
- # http://crbug.com/367768
- environment.AddWebsiteTest(Live("live", username_not_auto=True),
- disabled=True)
-
- # http://crbug.com/368690
- environment.AddWebsiteTest(One63("163"), disabled=True)
-
- # http://crbug.com/368690
- environment.AddWebsiteTest(Vube("vube"), disabled=True)
-
def saveResults(environment_tests_results, environment_save_path):
"""Save the test results in an xml file.
@@ -379,7 +367,7 @@ def RunTests(chrome_path, chromedriver_path, profile_path,
# to be shown. Automatic password saving results in no prompt.
run_prompt_tests = not enable_automatic_password_saving
- Tests(environment)
+ Tests(environment, tests)
if environment_tested_websites == TypeOfTestedWebsites.ALL_TESTS:
environment.AllTests(run_prompt_tests)

Powered by Google App Engine
This is Rietveld 408576698