[Password manager tests automation] Add ability to run single test.

[Password manager tests automation] Add ability to run single test.

Before this patch in order to run single test one needs to create
xml file with credentials for every site which can be tested.
This patch fixes this issue.

BUG=369521
R=vabr@chromium.org

Committed: https://crrev.com/5c9ecc223509281edaf41f650482982afef605c6
Cr-Commit-Position: refs/heads/master@{#319667}

[melandory, 2015-03-09 14:31:52]

Hi Vaclav,

review this CL please.

Does indentation in dictionary looks fine? I'm not sure that it should be like
this.

[vabr (Chromium), 2015-03-09 14:52:17]

LGTM,
Thanks for the fix, and for carefully keeping the test name validation!

Cheers,
Vaclav

https://codereview.chromium.org/994573002/diff/20001/components/test/data/pas...
File components/test/data/password_manager/automated_tests/run_tests.py (right):

https://codereview.chromium.org/994573002/diff/20001/components/test/data/pas...
components/test/data/password_manager/automated_tests/run_tests.py:227:
tests_to_run = user_selected_tests
You know Python better than me, so this is just to confirm: tests_to_run will be
keep its value also outside of the if-else branch, right?

(I'm asking, because in C++, this would not work, defining a variable inside an
if-block would limit its scope to that block.)

https://codereview.chromium.org/994573002/diff/20001/components/test/data/pas...
File components/test/data/password_manager/automated_tests/tests.py (right):

https://codereview.chromium.org/994573002/diff/20001/components/test/data/pas...
components/test/data/password_manager/automated_tests/tests.py:18:
DISABLED_TESTS = 0
Could you please add a
# TODO(vabr): Remove this option.
?
This looks like an unlikely use-case, and not supporting it will simplify the
class a little.

https://codereview.chromium.org/994573002/diff/20001/components/test/data/pas...
components/test/data/password_manager/automated_tests/tests.py:262: # Working
tests
nit: The comment here and on line 278 is no longer needed, thanks to the good
naming of the dictionary you introduced.

[melandory, 2015-03-09 15:00:27]

https://codereview.chromium.org/994573002/diff/20001/components/test/data/pas...
File components/test/data/password_manager/automated_tests/run_tests.py (right):

https://codereview.chromium.org/994573002/diff/20001/components/test/data/pas...
components/test/data/password_manager/automated_tests/run_tests.py:227:
tests_to_run = user_selected_tests
On 2015/03/09 14:52:17, vabr (Chromium) wrote:
> You know Python better than me, so this is just to confirm: tests_to_run will
be
> keep its value also outside of the if-else branch, right?
> 
> (I'm asking, because in C++, this would not work, defining a variable inside
an
> if-block would limit its scope to that block.)
Variable scope is determined by function or module.

https://codereview.chromium.org/994573002/diff/20001/components/test/data/pas...
File components/test/data/password_manager/automated_tests/tests.py (right):

https://codereview.chromium.org/994573002/diff/20001/components/test/data/pas...
components/test/data/password_manager/automated_tests/tests.py:18:
DISABLED_TESTS = 0
On 2015/03/09 14:52:17, vabr (Chromium) wrote:
> Could you please add a
> # TODO(vabr): Remove this option.
> ?
> This looks like an unlikely use-case, and not supporting it will simplify the
> class a little.

Done.

[vabr (Chromium), 2015-03-09 15:02:28]

lgtm

https://codereview.chromium.org/994573002/diff/20001/components/test/data/pas...
File components/test/data/password_manager/automated_tests/run_tests.py (right):

https://codereview.chromium.org/994573002/diff/20001/components/test/data/pas...
components/test/data/password_manager/automated_tests/run_tests.py:227:
tests_to_run = user_selected_tests
On 2015/03/09 15:00:27, melandory wrote:
> On 2015/03/09 14:52:17, vabr (Chromium) wrote:
> > You know Python better than me, so this is just to confirm: tests_to_run
will
> be
> > keep its value also outside of the if-else branch, right?
> > 
> > (I'm asking, because in C++, this would not work, defining a variable inside
> an
> > if-block would limit its scope to that block.)
> Variable scope is determined by function or module.

Acknowledged.

[melandory, 2015-03-09 16:01:10]

The CQ bit was checked by melandory@chromium.org

[melandory, 2015-03-09 16:01:10]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/994573002/#ps60001 (title:
"Rebased on top of master: ok.ru in new format.")

[commit-bot: I haz the power, 2015-03-09 16:01:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/994573002/60001

[melandory, 2015-03-09 16:15:19]

The CQ bit was unchecked by melandory@chromium.org

[melandory, 2015-03-09 16:17:23]

The CQ bit was checked by melandory@chromium.org

[commit-bot: I haz the power, 2015-03-09 16:17:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/994573002/60001

[commit-bot: I haz the power, 2015-03-09 17:27:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-09 17:27:51]

Patchset 4 (id:??) landed as
https://crrev.com/5c9ecc223509281edaf41f650482982afef605c6
Cr-Commit-Position: refs/heads/master@{#319667}