Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 994553002: Drop FIXME about unrestricted doubles in ScrollToOptions (Closed)

Created:
5 years, 9 months ago by Jens Widell
Modified:
5 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Drop FIXME about unrestricted doubles in ScrollToOptions The specification was updated[1] to use unrestricted doubles, so our code now matches the specification. [1] https://hg.csswg.org/drafts/rev/d8db5444d4d1 BUG=354298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191605

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/core/frame/ScrollToOptions.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL
5 years, 9 months ago (2015-03-09 14:03:29 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-09 23:10:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/994553002/1
5 years, 9 months ago (2015-03-10 06:18:12 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 07:37:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191605

Powered by Google App Engine
This is Rietveld 408576698