Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 994543003: Refactoring devtools_bridge JNI_OnLoad (Closed)

Created:
5 years, 9 months ago by michaelbai
Modified:
5 years, 9 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yurys, abarth-chromium, Aaron Boodman, yzshen+watch_chromium.org, devtools-reviews_chromium.org, darin (slow to review), aandrey+blink_chromium.org, ben+mojo_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactoring devtools_bridge JNI_OnLoad make it using base::android::OnJNIOnLoad BUG=447393 Committed: https://crrev.com/22e9acc2eeff3e50cf4a39849223a7730cef3f4c Cr-Commit-Position: refs/heads/master@{#319884}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -56 lines) Patch
M components/devtools_bridge.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D components/devtools_bridge/android/component_loader.h View 1 chunk +0 lines, -21 lines 0 comments Download
D components/devtools_bridge/android/component_loader.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M components/devtools_bridge/test/android/javatests/jni/jni_onload.cc View 1 chunk +24 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
michaelbai
5 years, 9 months ago (2015-03-09 19:16:36 UTC) #3
michaelbai
5 years, 9 months ago (2015-03-10 03:58:52 UTC) #5
mnaganov (inactive)
lgtm
5 years, 9 months ago (2015-03-10 09:33:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/994543003/20001
5 years, 9 months ago (2015-03-10 14:56:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 9 months ago (2015-03-10 15:33:15 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 15:33:56 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/22e9acc2eeff3e50cf4a39849223a7730cef3f4c
Cr-Commit-Position: refs/heads/master@{#319884}

Powered by Google App Engine
This is Rietveld 408576698