Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 99453003: Print test duration in verbose mode. (Closed)

Created:
7 years ago by M-A Ruel
Modified:
7 years ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Print test duration in verbose mode. This is useful to diagnose slow tests. Make this multiprocessing aware. Stop printing when the commands are added but use the proper message system instead. R=iannucci@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=238388

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -20 lines) Patch
M presubmit_canned_checks.py View 1 chunk +0 lines, -1 line 0 comments Download
M presubmit_support.py View 5 chunks +26 lines, -9 lines 2 comments Download
M tests/presubmit_unittest.py View 7 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
7 years ago (2013-12-02 16:57:03 UTC) #1
iannucci
lgtm https://codereview.chromium.org/99453003/diff/1/presubmit_support.py File presubmit_support.py (right): https://codereview.chromium.org/99453003/diff/1/presubmit_support.py#newcode1375 presubmit_support.py:1375: duration = time.time() - start finally?
7 years ago (2013-12-02 19:36:38 UTC) #2
M-A Ruel
https://codereview.chromium.org/99453003/diff/1/presubmit_support.py File presubmit_support.py (right): https://codereview.chromium.org/99453003/diff/1/presubmit_support.py#newcode1375 presubmit_support.py:1375: duration = time.time() - start On 2013/12/02 19:36:38, iannucci ...
7 years ago (2013-12-02 21:23:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/99453003/1
7 years ago (2013-12-03 13:53:23 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-03 13:55:23 UTC) #5
Message was sent while issue was closed.
Change committed as 238388

Powered by Google App Engine
This is Rietveld 408576698