Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 994523002: [turbofan] Make inlining independent of typing. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make inlining independent of typing. The JSInliner used to load the context from the JSFunction node at runtime, which introduced a HeapConstant (because we had to materialize the JSFunction after context specialization) and a LoadField operation, independent whether the inlinee actually uses the context. This is rather cumbersome currently, and therefore this is now changed to just embed the context constant instead. Once we do inlining based on SharedFunctionInfo rather than JSFunction, we should reconsider this decision and come up with a proper heuristic. BUG=v8:3952 LOG=n R=mstarzinger@chromium.org Committed: https://crrev.com/eacd6d8b7d175032b65aa65fa11c9419abdaa236 Cr-Commit-Position: refs/heads/master@{#27069}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -31 lines) Patch
M src/compiler/js-inlining.cc View 6 chunks +15 lines, -29 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Benedikt Meurer
5 years, 9 months ago (2015-03-09 12:41:43 UTC) #1
Benedikt Meurer
PTAL
5 years, 9 months ago (2015-03-09 12:42:00 UTC) #2
Michael Starzinger
LGTM.
5 years, 9 months ago (2015-03-09 13:01:03 UTC) #3
Benedikt Meurer
Committed patchset #1 (id:1) manually as eacd6d8b7d175032b65aa65fa11c9419abdaa236 (presubmit successful).
5 years, 9 months ago (2015-03-09 13:01:50 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 13:01:57 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eacd6d8b7d175032b65aa65fa11c9419abdaa236
Cr-Commit-Position: refs/heads/master@{#27069}

Powered by Google App Engine
This is Rietveld 408576698