Preliminary atomic patch

ui/ozone/platform/drm/gpu/drm_device.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_OZONE_PLATFORM_DRM_GPU_DRM_DEVICE_H_
 #define UI_OZONE_PLATFORM_DRM_GPU_DRM_DEVICE_H_
 
 #include <stdint.h>
 
 #include <vector>
@@ skipping 136 matching lines @@
   virtual bool CreateDumbBuffer(const SkImageInfo& info,
                                 uint32_t* handle,
                                 uint32_t* stride,
                                 void** pixels);
 
   virtual void DestroyDumbBuffer(const SkImageInfo& info,
                                  uint32_t handle,
                                  uint32_t stride,
                                  void* pixels);
 
+  virtual bool CommitProperties(drmModePropertySet* properties,

[dnicoara, 2015/03/09 20:10:40]

This will need to be mocked in test/mock_drm_device.h

[achaulk, 2015/03/09 20:23:48]

Done.

+                                uint32_t flags,

[dnicoara, 2015/03/09 20:10:40]

|flags| and |user_ptr| are never set to different values. Can we just hide them
in the implementation and not pass them in?

[achaulk, 2015/03/09 20:23:48]

They will likely be set to handle some sort of callbacks later on, once that's
figured out

[dnicoara, 2015/03/09 20:42:58]

Are you planing on adding more functionality part of this patch?

If not, we should add these flags later. It would be nice to have |user_ptr| of
some specific type.

[achaulk, 2015/03/09 20:55:18]

Not yet, since we don't even have a complete definition yet, but I suspect flags
will specify what events we want and the user_ptr will just be a generic
callback pointer, but the actual mechanism is unknown for now

[dnicoara, 2015/03/09 20:57:26]

For the callback, we can do the same as SchedulePageFlip and provide a concrete
PageFlipCallback.

[achaulk, 2015/03/09 21:41:00]

Sure, I'll just reuse the same one until we know more about the implementation

+                                void* user_ptr);
+
   // Drm master related
   virtual bool SetMaster();
   virtual bool DropMaster();
 
   int get_fd() const { return file_.GetPlatformFile(); }
 
   base::FilePath device_path() const { return device_path_; }
 
   HardwareDisplayPlaneManager* plane_manager() { return plane_manager_.get(); }
 
@@ skipping 18 matching lines @@
 
   // Watcher for |fd_| listening for page flip events.
   scoped_refptr<IOWatcher> watcher_;
 
   DISALLOW_COPY_AND_ASSIGN(DrmDevice);
 };
 
 }  // namespace ui
 
 #endif  // UI_OZONE_PLATFORM_DRM_GPU_DRM_DEVICE_H_