Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 994433002: [turbofan] Skip function entry stack check for inlinee. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
Jarin
CC:
Michael Starzinger, Sven Panne, v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Skip function entry stack check for inlinee. This is currently the cleanest approach to avoid the useless stack check during inlining. We might be able to just remove the useless stack checks later when we have a phase that also takes care of removing redundant stack checks on loop back edges (which we do not generate currently). On the other hand, the flag introduced here might be useful when building code stubs/builtins/dom stubs using JS based DSL, because you certainly don't want a JS-level stack check in a code stub. R=jarin@chromium.org BUG=v8:3952 LOG=n Committed: https://crrev.com/4b6afb84320a91540db584a88c3fbcd818b53f57 Cr-Commit-Position: refs/heads/master@{#27058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M src/compiler/ast-graph-builder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
5 years, 9 months ago (2015-03-09 05:52:23 UTC) #1
Benedikt Meurer
Jaro: PTAL (Michi is OK with this change, but he don't want to be the ...
5 years, 9 months ago (2015-03-09 05:53:08 UTC) #2
Jarin
lgtm
5 years, 9 months ago (2015-03-09 07:17:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/994433002/1
5 years, 9 months ago (2015-03-09 07:25:15 UTC) #5
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 07:29:08 UTC) #7
Benedikt Meurer
Committed patchset #1 (id:1) manually as 4b6afb84320a91540db584a88c3fbcd818b53f57 (presubmit successful).
5 years, 9 months ago (2015-03-09 07:31:08 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 07:31:11 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b6afb84320a91540db584a88c3fbcd818b53f57
Cr-Commit-Position: refs/heads/master@{#27058}

Powered by Google App Engine
This is Rietveld 408576698