Issue 99443005: Enforce HTML range restriction on setting unsigned attribute values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99443005: Enforce HTML range restriction on setting unsigned attribute values. (Closed)

Created:
7 years ago by sof

Modified:
7 years ago

Reviewers:
haraken, jochen (gone - plz use gerrit), Mike West

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Enforce HTML range restriction on setting unsigned attribute values. The HTML spec requires that reflected attributes over unsigned longs are kept to a limited range [0, 2^31) on setting & getting, http://www.whatwg.org/specs/web-apps/current-work/#reflect No such clamping was in place for the upper bound; enforce it when setting the unsigned long attribute. R= BUG=316122 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163778

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	LayoutTests/fast/dom/script-tests/unsigned-long-attribute-reflection.js	View		1 chunk	+4 lines, -6 lines	0 comments	Download
	M	Source/core/dom/Element.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/99443005/1

7 years ago (2013-12-12 10:01:25 UTC) #3

Message was sent while issue was closed.

Change committed as 163778