Calls BrowserAccessibility::IsCellOrTableHeaderRole() with a correct instance.

Calls BrowserAccessibility::IsCellOrTableHeaderRole() with a correct instance.

The problem was caused by using IsCellOrTableHeaderRole with
its own browserAccessibility_ on checking cell index.
This patch makes IsCellOrTableHeaderRole be called with
a correct instance.

BUG=465087
R=dmazzoni@chromium.org

Committed: https://crrev.com/a7c5b29eb875d894d9ea9757ced5a0ce0335ca54
Cr-Commit-Position: refs/heads/master@{#320203}

[je_julie(Not used), 2015-03-11 16:07:10]

Dominic, PTAL.

[dmazzoni, 2015-03-11 16:31:41]

https://codereview.chromium.org/994373003/diff/1/content/browser/accessibilit...
File content/browser/accessibility/browser_accessibility.cc (right):

https://codereview.chromium.org/994373003/diff/1/content/browser/accessibilit...
content/browser/accessibility/browser_accessibility.cc:687: bool
BrowserAccessibility::IsCellOrTableHeaderRole(int32 role) const {
I don't think it's necessary to add this argument - see comment below.

https://codereview.chromium.org/994373003/diff/1/content/browser/accessibilit...
File content/browser/accessibility/browser_accessibility_cocoa.mm (right):

https://codereview.chromium.org/994373003/diff/1/content/browser/accessibilit...
content/browser/accessibility/browser_accessibility_cocoa.mm:1149: if
(!browserAccessibility_->IsCellOrTableHeaderRole(cell->GetRole()))
I think this line was the one that had the bug, right?

Can you just call cell->IsCellOrTableHeaderRole() instead?

[je_julie(Not used), 2015-03-11 23:21:16]

Dominic, Thanks for your point.
I updated patch. PTAL.

https://codereview.chromium.org/994373003/diff/1/content/browser/accessibilit...
File content/browser/accessibility/browser_accessibility_cocoa.mm (right):

https://codereview.chromium.org/994373003/diff/1/content/browser/accessibilit...
content/browser/accessibility/browser_accessibility_cocoa.mm:1149: if
(!browserAccessibility_->IsCellOrTableHeaderRole(cell->GetRole()))
You're right. I didn't see it correctly.

On 2015/03/11 16:31:41, dmazzoni wrote:
> I think this line was the one that had the bug, right?
> 
> Can you just call cell->IsCellOrTableHeaderRole() instead?

[dmazzoni, 2015-03-11 23:42:24]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2015-03-11 23:42:25]

lgtm

[commit-bot: I haz the power, 2015-03-11 23:43:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/994373003/20001

[commit-bot: I haz the power, 2015-03-12 01:25:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-12 01:26:15]

Patchset 2 (id:??) landed as
https://crrev.com/a7c5b29eb875d894d9ea9757ced5a0ce0335ca54
Cr-Commit-Position: refs/heads/master@{#320203}